Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-4086] Added initial number in FlatList #4089

Merged

Conversation

aliabbasmalik8
Copy link
Contributor

@aliabbasmalik8 aliabbasmalik8 commented Jul 15, 2021

Details

Added initialNumToRender in FlatList

Fixed Issues

$ #4086

Tests

QA Steps

  1. Navigate to a chat with many comments
  2. Chat loads with enough items to fill up with screen

Previous Result

The chat looks half loaded and lags before remaining items appear

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen.Recording.2021-07-15.at.2.25.17.AM.mov

Mobile Web

Screen.Recording.2021-07-15.at.1.36.33.PM.mov

Desktop

Screen.Recording.2021-07-15.at.1.12.00.PM.mov

iOS

Screen.Recording.2021-07-15.at.1.14.47.PM.mov

Android

Screenrecorder-2021-07-16-01-41-49-671_0_COMPRESSED.mp4

@aliabbasmalik8 aliabbasmalik8 requested a review from a team as a code owner July 15, 2021 20:53
@MelvinBot MelvinBot requested review from pecanoro and removed request for a team July 15, 2021 20:53
@pecanoro pecanoro merged commit 219daeb into Expensify:main Jul 15, 2021
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.78-3🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@isagoico
Copy link

@aliabbasmalik8 Hello 👋 any QA tests needed here?

@aliabbasmalik8
Copy link
Contributor Author

aliabbasmalik8 commented Jul 16, 2021

@isagoico PR description updated with QA tests

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.79-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants