Sign in - infinite spinner for some users with incorrect NVP structure

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open app
2. Login

Expected Result:

User should be able to login

Actual Result:

User is unable to login. Infinite spinner
Issue repro after app reinstall

Workaround:

Unknown

Platform:

Where is this issue occurring?

Web
iOS ✔️
Android
Desktop App
Mobile Web

Version Number:
1.0.78.0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5152177_IMG_0959.mp4

Expensify/Expensify Issue URL:

View all open jobs on Upwork

[MelvinBot]

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[johnmlee101]

@kavimuru Can you re-test this? It seems like we had an issue with our backend which may have caused this

[mvtglobally]

@johnmlee101 we are still able to repro. Video
Can you try to login with:
Mvtutest@gmail.com
Password1

[Jag96]

Looks like the same issue happens on web, looking at the logs it seems to be an Auth issue: logs

The error is similar to https://github.com/Expensify/Expensify/issues/170673, so I'm guessing this is related to https://github.com/Expensify/Auth/pull/5747. cc @marcaaron

[marcaaron]

Hmm interesting. I've actually been seeing similar behavior for months locally. But the logs do make it seem like there is something we missed.

[marcaaron]

Is this only reproducible on iOS ?

[Jag96]

I reproduced on web by using the credentials in #4058 (comment)

[marcaaron]

Alright so I did some investigating and thought it might have to do with the pinned reports NVP.

Here's what mine looks like atm

Ignoring the fact that there's a 0 in there for now 😄 ... we can see it's an array

tester's NVP

Maybe there was some migration at some point? I reset tester's NVP and was able to log in. So I think there's nothing to do on the code side, but unsure how many accounts have this old NVP and will be blocked from logging in.

[Jag96]

Hmm interesting, I think if we can run a query to check it'd be worth it. Then if there are affected accounts we can add a migration.

[marcaaron]

Honestly, I'm super confused how we were even able to end up with this NVP. It looks like the code that sets this was seeting a csv string before and then set an array but never object 🤷‍♂️

[Jag96]

After investigating it looks like there are only 3 affected accounts, and it seems that they're still able to load e.cash without any issues, so closing this one out. I'll clean up the 3 affected accounts in the internal issue.