Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed scrolling and layout #3988

Merged
merged 3 commits into from
Jul 13, 2021
Merged

fixed scrolling and layout #3988

merged 3 commits into from
Jul 13, 2021

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Jul 12, 2021

Details

Fixed Issues

$ Fixes #3950
$ Fixes #4000

Tests | QA Steps

  • Request a call

    1. Go to staging.expensify.cash
    2. Sign into vanniac27@pyjgoingtd.com with the password asdfASDF00.
    3. Navigate to the chat with Concierge. Click the call button.
    4. Check the call me button
  • Workspace Invite Page

    1. Lunch the app
    2. Log in with expensifail account
    3. Click on the FAB button
    4. Select the New Workspace
    5. Chose a name and click Get Started
    6. Select the People
    7. Click the Assignee
    8. Click Invite
    9. Enter the email address
    10. Add a Personal Message in the box.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web | Desktop

invite-w.mp4
call-w.mp4

Mobile Web

both-m.mp4

iOS

Android

both-a.mp4

@parasharrajat parasharrajat marked this pull request as ready for review July 13, 2021 16:10
@parasharrajat parasharrajat requested a review from a team as a code owner July 13, 2021 16:10
@MelvinBot MelvinBot requested review from tgolen and removed request for a team July 13, 2021 16:10
@tgolen tgolen merged commit 8c98a64 into Expensify:main Jul 13, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.77-6🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@isagoico
Copy link

PR is still failing because of #4060

@isagoico
Copy link

Retested this and it was a pass! 🎉

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.79-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@parasharrajat parasharrajat deleted the scrollview branch November 20, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants