Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hold for Payment - 21 July] mWeb - Profile - Call me button is overlapping with text in mweb Safari #3950

Closed
isagoico opened this issue Jul 9, 2021 · 15 comments · Fixed by #3988
Assignees
Labels
Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2

Comments

@isagoico
Copy link

isagoico commented Jul 9, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel! https://www.upwork.com/jobs/~013c20fc13448fc687


Action Performed

  1. Go to https://staging.expensify.cash
  2. Sign into vanniac27@pyjgoingtd.com with the password asdfASDF00.
  3. Navigate to the chat with Concierge. Click the call button.
  4. Check the call me button

Expected Result

Call me button isn't overlapping with text in mweb Safari

Actual Result

Call me button is overlapping with text in mweb Safari

Workaround:

Unknown

Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web ✔️

Version Number: 1.0.76

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:
Issue is reproducible in production.

image

Expensify/Expensify Issue URL:

View all open jobs on Upwork


Found while executing #3777

@MelvinBot
Copy link

Triggered auto assignment to @sketchydroide (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@shawnborton
Copy link
Contributor

I think this is expected behavior because the green button is fixed to the bottom of the viewport.

@parasharrajat
Copy link
Member

parasharrajat commented Jul 9, 2021

But Maybe we forget to add the scroll view behind and she is not able to scroll.

Edit.

  1. yes it needs a Scrollview.

Proposal

To fix this we need to wrap the view in ScrollView as we do for other screens so that users can scroll the page.

@roryabraham
Copy link
Contributor

@sketchydroide This can be external, so I'm going to add the label to get the ball rolling here.

@roryabraham roryabraham added the External Added to denote the issue can be worked on by a contributor label Jul 9, 2021
@MelvinBot
Copy link

Triggered auto assignment to @laurenreidexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@sketchydroide
Copy link
Contributor

Thanks @roryabraham

@laurenreidexpensify
Copy link
Contributor

Added to Upwork - https://www.upwork.com/jobs/~013c20fc13448fc687

@MelvinBot
Copy link

Triggered auto assignment to @tgolen (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@laurenreidexpensify laurenreidexpensify added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 12, 2021
@aliabbasmalik8
Copy link
Contributor

Can fix by replacing View with ScrollView here
https://github.com/Expensify/Expensify.cash/blob/f61e6d99b3175a04649187efdbaa004e35ca2ad4/src/pages/RequestCallPage.js#L155

phone number label is also hidden on the small screen. This issue also fix by adding ScrollView

image

@parasharrajat
Copy link
Member

Posted the Proposal here #3950 (comment).
With respect to this, there is a similar issue that will be fixed as well

@isagoico
Copy link
Author

Issue reproducible during KI retests

@tgolen
Copy link
Contributor

tgolen commented Jul 12, 2021

@parasharrajat Your proposal looks good and yours was posted before @aliabbasmalik8. You have my 🟢 to work on this.

@laurenreidexpensify
Copy link
Contributor

Hired you in Upwork @parasharrajat

@laurenreidexpensify laurenreidexpensify added Weekly KSv2 and removed Daily KSv2 labels Jul 14, 2021
@laurenreidexpensify laurenreidexpensify changed the title mWeb - Profile - Call me button is overlapping with text in mweb Safari [Hold for Payment - 21 July] mWeb - Profile - Call me button is overlapping with text in mweb Safari Jul 14, 2021
@laurenreidexpensify
Copy link
Contributor

@parasharrajat just a heads up, i'm having issues with issuing payment on Upwork - I will try again in a few hours

@laurenreidexpensify
Copy link
Contributor

Paid 👍🏽

@mallenexpensify mallenexpensify removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants