Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update logic to account for middle names #3777

Merged
merged 4 commits into from
Jul 1, 2021
Merged

Update logic to account for middle names #3777

merged 4 commits into from
Jul 1, 2021

Conversation

jasperhuangg
Copy link
Contributor

@jasperhuangg jasperhuangg commented Jun 28, 2021 •
edited
Loading

Details

The logic in the RequestCallPage was assuming that a user's display name would only include their first and last names, and wasn't accounting for names that were longer than 2 words. This PR fixes it to take the first and last names correctly, even for names that are longer than 2 words.

Fixed Issues

N/A (see screenshot for the issue)
Screen Shot 2021-06-28 at 8 59 09 PM

Tests

  1. Set a display name for yourself that's more than just two words.
  2. Navigate to the request call page.
  3. Verify that the last name form is prefilled correctly.

QA Steps

  1. Sign into vanniac27@pyjgoingtd.com with the password asdfASDF00.
  2. Navigate to the chat with Concierge. Click the call button.
  3. Verify that the first name input is auto-filled with "Name1", and the last name input is auto-filled with "Name3".

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@jasperhuangg jasperhuangg self-assigned this Jun 28, 2021
@jasperhuangg jasperhuangg marked this pull request as ready for review June 28, 2021 13:16
@jasperhuangg jasperhuangg requested a review from a team as a code owner June 28, 2021 13:16
@MelvinBot MelvinBot requested review from sketchydroide and removed request for a team June 28, 2021 13:17
sketchydroide
sketchydroide suggested changes Jun 30, 2021
View reviewed changes
Copy link
Contributor

@sketchydroide sketchydroide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good, I have a doubt with one of the logic component

@jasperhuangg
Copy link
Contributor Author

@sketchydroide Should be good for another review, thanks!

sketchydroide
sketchydroide approved these changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@sketchydroide sketchydroide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK looks good

@sketchydroide sketchydroide merged commit de44278 into main Jul 1, 2021
@sketchydroide sketchydroide deleted the jasper-requestCallPageMiddleNames branch July 1, 2021 15:26
@OSBotify
Copy link
Contributor

OSBotify commented Jul 1, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Jul 7, 2021
Closed
57 tasks
@roryabraham
Copy link
Contributor

Unfortunately the deploy comments are not working right now. This was deployed to staging yesterday.

@isagoico isagoico mentioned this pull request Jul 9, 2021
Closed
@MariaHCD MariaHCD mentioned this pull request Feb 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sketchydroide sketchydroide sketchydroide approved these changes

Assignees

@jasperhuangg jasperhuangg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jasperhuangg @OSBotify @roryabraham @sketchydroide