Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] fix: suppress distracting log box warnings #4031

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

jsamr
Copy link
Collaborator

@jsamr jsamr commented Jul 14, 2021

@marcaaron

Details

Suppress warnings which cause are well understood and can be safely ignored, as discussed in #4014

Fixed Issues

#4014

Tests

Launch the app in dev mode and make sure the suppressed warnings are not shown anymore.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

I don't think it's relevant to provide screenshots here, but if you really require it I will.

@jsamr jsamr requested a review from a team as a code owner July 14, 2021 11:16
@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@MelvinBot MelvinBot requested review from mountiny and removed request for a team July 14, 2021 11:16
@jsamr
Copy link
Collaborator Author

jsamr commented Jul 14, 2021

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@mountiny mountiny merged commit 2c8df98 into Expensify:main Jul 14, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.77-6🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@isagoico
Copy link

@mountiny We're unable to test this PR from our side. Can this be tested on your side and let me know if it's a pass? Thanks in advance 😊

@marcaaron
Copy link
Contributor

This only relevant on dev so should have been marked as No QA

@marcaaron marcaaron changed the title fix: suppress distracting log box warnings [No QA] fix: suppress distracting log box warnings Jul 15, 2021
@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.79-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants