Start including betas in the call to getSidebarOptions #3840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
TomatoToaster
approved these changes
Jun 30, 2021
There was a problem hiding this comment.
Not sure how this was working locally only before, but great find!
Oh duh because of this: https://github.com/Expensify/Expensify.cash/blob/1275f58c4a171c03cbe01e7fa14cebcfdb280f85/src/libs/Permissions.js#L11
github-actions bot
pushed a commit
that referenced
this pull request
Jun 30, 2021
Start including betas in the call to getSidebarOptions (cherry picked from commit d627947)
This was referenced Jun 30, 2021
|
🚀 Cherry-picked to staging in version: 1.0.75-5🚀
|
This was referenced Jul 7, 2021
95 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@TomatoToaster please review
Details
This fixes the issue of the
#adminsrooms not showing up in the LHN. It's because thebetasparam was not being passed togetSidebarOptions. Thus, it was mistakenly assumed that we were not on the beta.Fixed Issues
Tests