-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA] Configured Reanimated 2 for Drawer #4081
Conversation
@@ -86,7 +86,7 @@ | |||
"react-native-permissions": "^3.0.1", | |||
"react-native-picker-select": "8.0.4", | |||
"react-native-plaid-link-sdk": "^7.0.5", | |||
"react-native-reanimated": "^2.1.0", | |||
"react-native-reanimated": "^2.3.0-alpha.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you just do npm i react-native-reanimated@next
? Latest release on GH looks like 2.2.0
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I picked the most stable from the website https://docs.swmansion.com/react-native-reanimated/docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, this looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Please do update pods and commit the result anytime a diff --git a/ios/Podfile.lock b/ios/Podfile.lock
index 05fe3d6ea..1e8aa5bea 100644
--- a/ios/Podfile.lock
+++ b/ios/Podfile.lock
@@ -461,7 +461,7 @@ PODS:
- React-Core
- RNPermissions (3.0.1):
- React-Core
- - RNReanimated (2.1.0):
+ - RNReanimated (2.3.0-alpha.1):
- DoubleConversion
- FBLazyVector
- FBReactNativeSpec this change should have been included here 🙃 |
Oh sorry. Totally forgot that I upgraded to the version to pod needs to updated as well. |
🚀 Deployed to staging in version: 1.0.79-5🚀
|
🚀 Deployed to production in version: 1.0.80-2🚀
|
Details
Fixed Issues
$ #3972
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android