Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong active report on LHN #4004

Merged
merged 2 commits into from
Jul 13, 2021
Merged

Fix wrong active report on LHN #4004

merged 2 commits into from
Jul 13, 2021

Conversation

rdjuric
Copy link
Contributor

@rdjuric rdjuric commented Jul 13, 2021

Details

The componentDidMount lifecycle isn't fired when we navigate to a ReportScreen from the Search/FAB. So we need to call our storeCurrentlyViewedReport method in the componentDidUpdate lifecycle (after checking for a report change).

Fixed Issues

$ #3982

Tests

Chat switcher scenario:

  1. Open chat switcher via CMD + K or in windows use the search function
  2. Search for an user
  3. Select any user
  4. LHN should show the selected user as the active chat

Request Money scenario:

  1. Click on FAB
  2. Click on request money
  3. Set an amount
  4. Search for any user
  5. Finish the request money flow
  6. LHN should show the selected user as the active chat

QA Steps

Same as above.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web.mov

Mobile Web

Desktop

desktop.mov

iOS

Android

@rdjuric rdjuric marked this pull request as ready for review July 13, 2021 15:28
@rdjuric rdjuric requested a review from a team as a code owner July 13, 2021 15:28
@MelvinBot MelvinBot requested review from pecanoro and removed request for a team July 13, 2021 15:28
src/pages/home/ReportScreen.js Outdated Show resolved Hide resolved
Co-authored-by: Rocio Perez <pecanoro@users.noreply.github.com>
@rdjuric rdjuric requested a review from pecanoro July 13, 2021 16:57
@rdjuric
Copy link
Contributor Author

rdjuric commented Jul 13, 2021

Updated @pecanoro

@pecanoro pecanoro merged commit bd675f9 into Expensify:main Jul 13, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.77-6🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.79-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants