-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Treat IOU debts as pinned reports in the LHN #3925
Conversation
Converting to draft while I fix/update tests |
Updated tests and screenshots, this is ready for review! |
@johnmlee101 friendly bump! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging in version: 1.0.77-6🚀
|
New Chat - List of the Contacts area is not organized in alphabetical orderExpected Result:Per the step 7 of the PR, Contacts listed must be in alphabetical order Actual Result:Contacts are not in alphabetical order Actions Performed:
Platform:iOS ✔️ Build:1.0.78-0 Notes/Images/Video:Bug5153398_Pr_3925_Last.mp4 |
Looks like step 7 is failing but the same issue is reproducible in production. @Jag96 Should I open a separate issue for this or do you want to address this on this PR? |
Ah, I just added that step since that was what I was seeing when I tested on my account. Scrolling all the way down on production though, I see that all the contacts aren't all in alphabetical order, and looking back at the code it seems this isn't being done explicitly, so I think we can leave this alone for now (not an issue). Thanks for the double-check! |
🚀 Deployed to production in version: 1.0.79-4🚀
|
Details
This PR updates the LHN to show IOUs the user owes at the top of the LHN with pinned reports.
Fixed Issues
$ #3389
Tests/QA
and the contacts below are listed in alphabetical order.Tested On
Screenshots
Web/Desktop/Mobile Web
iOS/Android