Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat IOU debts as pinned reports in the LHN #3925

Merged
merged 5 commits into from
Jul 14, 2021
Merged

Conversation

Jag96
Copy link
Contributor

@Jag96 Jag96 commented Jul 8, 2021

Details

This PR updates the LHN to show IOUs the user owes at the top of the LHN with pinned reports.

Fixed Issues

$ #3389

Tests/QA

  1. Sign into account A and send some requests to other users for different amounts
  2. Sign into account B and send a request to account A so that account A owes account B
  3. Sign into account C and send a request to account A larger than the amount in step 2 so that account A owes account C
  4. In account A, change the Priority Mode (click user profile image -> preferences -> priority mode) to #focus, confirm that after navigating back to the LHN all reports are shown in alphabetical order, and unpinned IOU debt reports are still shown in the LHN
  5. Change the Priority Mode back to Recent Mode, confirm that after navigating back to the LHN the pinned reports are at the top, followed by the debts in order from highest to lowest amount owed, followed by other chats
  6. Hit the search icon, confirm that the results are still shown in recent order, and not in order of pinned reports or debts.
  7. Hit the green plus button and select a new chat, confirm that the results still show the recent chats in order of recently viewed, and the contacts below are listed in alphabetical order.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web/Desktop/Mobile Web

#focus Recent
image image

iOS/Android

#focus Recent
image image

@Jag96 Jag96 self-assigned this Jul 8, 2021
@Jag96 Jag96 requested a review from a team as a code owner July 8, 2021 06:07
@MelvinBot MelvinBot requested review from johnmlee101 and removed request for a team July 8, 2021 06:07
@Jag96 Jag96 changed the title Tread IOU debts as pinned reports in the LHN Treat IOU debts as pinned reports in the LHN Jul 8, 2021
@Jag96 Jag96 marked this pull request as draft July 8, 2021 06:16
@Jag96
Copy link
Contributor Author

Jag96 commented Jul 8, 2021

Converting to draft while I fix/update tests

@Jag96 Jag96 marked this pull request as ready for review July 9, 2021 02:05
@Jag96
Copy link
Contributor Author

Jag96 commented Jul 9, 2021

Updated tests and screenshots, this is ready for review!

@Jag96
Copy link
Contributor Author

Jag96 commented Jul 14, 2021

@johnmlee101 friendly bump!

Copy link
Contributor

@johnmlee101 johnmlee101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@johnmlee101 johnmlee101 merged commit 9903cdb into main Jul 14, 2021
@johnmlee101 johnmlee101 deleted the joe-pin-owed-balances branch July 14, 2021 14:58
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.77-6🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@kavimuru
Copy link

New Chat - List of the Contacts area is not organized in alphabetical order

Expected Result:

Per the step 7 of the PR, Contacts listed must be in alphabetical order

Actual Result:

Contacts are not in alphabetical order

Actions Performed:

  1. Open e.cash in Web
  2. Click the green plus button and select a new chat
  3. Scroll down to the Contacts area

Platform:

iOS ✔️
mWeb ✔️
Android ✔️
Web ✔️
Desktop ✔️

Build:

1.0.78-0

Notes/Images/Video:

Bug5153398_Pr_3925_Last.mp4

Bug5153398_image__4_

@isagoico
Copy link

Looks like step 7 is failing but the same issue is reproducible in production. @Jag96 Should I open a separate issue for this or do you want to address this on this PR?

@Jag96
Copy link
Contributor Author

Jag96 commented Jul 16, 2021

Ah, I just added that step since that was what I was seeing when I tested on my account. Scrolling all the way down on production though, I see that all the contacts aren't all in alphabetical order, and looking back at the code it seems this isn't being done explicitly, so I think we can leave this alone for now (not an issue). Thanks for the double-check!

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.79-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants