Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make chats that have owed balance behave as pinned chats (even in #focus mode) #3389

Closed
isagoico opened this issue Jun 7, 2021 · 4 comments
Assignees
Labels
Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2

Comments

@isagoico
Copy link

isagoico commented Jun 7, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Expected Result:

Chats that have owed balance should display on top of the LHN so the user doesn't lose track of owed amounts. This behaviour should be the same even in #focus mode.

Actual Result:

Chats that have owed balance don't show on the top of the LHN.

Action Performed:

  1. Log in to e.cash on account A
  2. Request money to account B
  3. Log in as Account B
  4. Enable focus mode.

Workaround:

User has to manually look in the list of conversations for chats that have owed balance.

Platform:

Where is this issue occurring?

Web ✔️
iOS✔️
Android✔️
Desktop App✔️
Mobile Web✔️

Version Number: 1.0.63-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

image

Expensify/Expensify Issue URL:

View all open jobs on Upwork


From @quinthar https://expensify.slack.com/archives/C01GTK53T8Q/p1623031046030500

When you owe someone, that chat should behave as if pinned (ie, always visible in the LHN even in #focus mode)

@MelvinBot
Copy link

Triggered auto assignment to @nickmurray47 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@rushatgabhane
Copy link
Member

rushatgabhane commented Jun 8, 2021

@isagoico Just to clarify, you want owed balance always at the top; sorted alphabetically / by amount owed / by time the money was requested?

@nickmurray47 nickmurray47 added the External Added to denote the issue can be worked on by a contributor label Jun 9, 2021
@MelvinBot
Copy link

Triggered auto assignment to @stephanieelliott (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@nickmurray47
Copy link
Contributor

I think this can be a weekly given the scope of the changes.

@Jag96 Jag96 self-assigned this Jul 8, 2021
@Jag96 Jag96 added Weekly KSv2 and removed Daily KSv2 labels Jul 8, 2021
@Jag96 Jag96 added the Reviewing Has a PR in review label Jul 8, 2021
@botify botify closed this as completed Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants