fix: Document Picker crash on IOS

[parasharrajat]

Details

We had to put a delay between modal is closed and picker opens the document chooser.

Fixed Issues

Fixes #3543

Tests | QA Steps

1. Open any conversation on E.cash mobile app.
2. click Add attachment from plus icon.
3. Select the add attachment option and

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Mobile Web

Desktop

iOS

ios-picker.mp4

Android

1623693284878.mp4

[Julesssss]

I was going to suggest reducing this to 100ms, as 200ms is quite noticeable as a user. But that's how we got into this mess in the first place, so I won't block on that.

[parasharrajat]

I checked that 100ms does not work. but I am looking into other factors which cause this setTimout. No luck so far.

[roryabraham]

Great job finding the solution here @parasharrajat! 🎉

Do you know if there is an issue in the react-native-modal repo for this? It seems that onModalHide is being executed before the modal is completely closed, which it should not. If there's no issue, should we consider opening one?

[parasharrajat]

They do seem to fix it here by calling it after state update. https://github.com/react-native-modal/react-native-modal/blob/b580105f4b2b4e1163bed1228f241b16ea17dacb/src/modal.tsx#L697. but I don't think it can be improved further but nobody knows. It could be an issue with the React-native modal. Not sure about opening another issue. there are a couple of closed ones there.

[parasharrajat]

@roryabraham it seems we missed the Slack Webhook Url Env for Gh actions.

[roryabraham]

@roryabraham it seems we missed the Slack Webhook Url Env for Gh actions.

This is a known issue for GH Actions where your repo secrets randomly disappear for some workflow runs for no reason. 😠

[ctkochan22]

Confirmed with @roryabraham that we are good to merge

[OSBotify]

🚀 Cherry-picked to staging in version: 1.0.68-4🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production in version: 1.0.68-4🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to staging in version: 1.0.68-5🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production in version: 1.0.73-3🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅