Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: Expensify.cash 2021-06-08 #3450

Closed
49 tasks done
OSBotify opened this issue Jun 8, 2021 · 35 comments
Closed
49 tasks done

Deploy Checklist: Expensify.cash 2021-06-08 #3450

OSBotify opened this issue Jun 8, 2021 · 35 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Jun 8, 2021

Release Version: 1.0.68-4
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

cc @Expensify/applauseleads

@isagoico
Copy link

isagoico commented Jun 9, 2021

Starting QA

@isagoico isagoico added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Jun 9, 2021
@isagoico
Copy link

isagoico commented Jun 9, 2021

Should I check these off #3456 and #3445 and test them when the prod build is deployed? CC @AndrewGable @roryabraham

@roryabraham
Copy link
Contributor

Should I check these off #3456 and #3445 and test them when the prod build is deployed?

Yep! Just ping us before you run the next prod deploy and we'll verify that it worked. No worries, it's unlikely those PRs will break android prod deploys any more than they're already broken.

@isagoico isagoico removed the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Jun 9, 2021
@isagoico
Copy link

@roryabraham haven't added the DB label yet since there haven't been any changes

@roryabraham
Copy link
Contributor

@isagoico I'm investigating why there haven't been any changes here – there have been PRs merged since this was unlocked, which should update this issue.

@isagoico
Copy link

Oh y yeah I found it really weird that no changes were disolayed. Let me know when we can start QA.

@roryabraham
Copy link
Contributor

Looks like CP's may have broken the normal deploy workflow in an unexpected way – this version-bump PR includes changes that it should not, and has merge conflicts in the normal version-bump files

@stitesExpensify
Copy link
Contributor

Checking off #3512 in the deploy blocker section, we're not going to block on it.

@roryabraham
Copy link
Contributor

Okay, staging deploys are fixed now, but I'm going to have to manually update the checklist. It's missing PRs, but I have a PR here that should make it more robust and self-correcting in the future.

@isagoico
Copy link

Starting QA

@isagoico isagoico added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Jun 10, 2021
@roryabraham
Copy link
Contributor

roryabraham commented Jun 10, 2021

So @isagoico and I discussed this 1:1 a bit, but I just wanted to make a note of it here. Since Applause is starting QA so late in the day, @isagoico didn't want to guarantee 100% completion. So we aren't going to run a production deploy today, but we still wanted to get a QA cycle in so that we'll know ASAP if there are any new deploy blockers or regressions that need to be addressed.

@Julesssss
Copy link
Contributor

Resolved #3321 as the fix has been CP'd to staging.

@isagoico isagoico removed the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Jun 11, 2021
@Julesssss
Copy link
Contributor

Also #3482 & #3485

@Julesssss
Copy link
Contributor

Hey @roryabraham @isagoico. I think we need to keep the LockCashDeploys label attached to this don't we? Else additional PRs will be included as part of this release and might cause further deployBlockers to occur?

@isagoico
Copy link

mmm we usually remove the lock label after finishing regression (which it was finished earlier today) if there are deploy blockers during QA, I actually thought I had removed the label earlier today but looks like I didn't 🤦. On my 1:1 with @roryabraham he mentioned that there was not going to be a production deploy but didn't say anything about the lock label.

@roryabraham
Copy link
Contributor

roryabraham commented Jun 11, 2021

@isagoico, that was my mistake. I think we wanted to leave the lock label to prevent new PRs from being added to the release. Unfortunately we can't undo it at this point, and adding the label back will cause main to be deployed to staging.

Fortunately, we now have the ability to CP fixes to staging, so once the LockCashDeploys is next added to this issue, let's leave it there until we have resolved all deploy blockers via CPs. That way, any newly-merged PRs will be included in the next release instead of this one.

@roryabraham roryabraham added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Jun 11, 2021
@roryabraham
Copy link
Contributor

roryabraham commented Jun 11, 2021

Manually added the following PRs which were missing from this checklist:

Note: @AndrewGable @Jag96 This is something I always have to remember to do. PRs merged while the checklist is locked are not added to the checklist when the lock label is removed (only added to the next checklist if we run a prod deploy). But this PR should fix it, so I would love to merge + test that as soon as possible (after our next prod deploy).

@Julesssss
Copy link
Contributor

#3545 was also checked off as we no longer think it needs to block the release.

@roryabraham
Copy link
Contributor

roryabraham commented Jun 11, 2021

#3550 is being CP'd to staging, should fix #3543 in 1.0.68-1 🤞

Staging deploy happening here

@roryabraham
Copy link
Contributor

roryabraham commented Jun 11, 2021

CP'ing #3535 to staging: should fix #3488 and #3536 in 1.0.68-3 🤞

@isagoico
Copy link

Regression is finished!
1 issue found today:

  1. Web - IOU - Previously used currency appears for a brief moment for request/ split money #3560

PRs are finished too
No comments added 🎉

Thanks!

@isagoico
Copy link

isagoico commented Jun 12, 2021

#3510 checked off, will be worked on a separate issue

#3215 links are opening in a different tab now so it's a pass 🎉

@isagoico
Copy link

@roryabraham: While re testing the deploy blockers we were able to reproduce this issue:

  1. When signing into an account after signing out, you are brought to /r/ instead of a chat #3559

#3536 and #3488 were a pass. For #3543 I'm waiting for someone with iOS to check it since I don't have my iOS on my atm.

@isagoico
Copy link

#3543 is still reproducible, reopening the issue.

@Julesssss
Copy link
Contributor

Marked #3423 as resolved, as the raised issues were fixed and merged.

@Julesssss
Copy link
Contributor

I removed #3215 from being a deployBlocker, as this comment proves it did not introduce the iOS attachment regression.

@Julesssss
Copy link
Contributor

@isagoico I am happy to confirm all deployBlockers have been resolved

@isagoico
Copy link

That's great news 🎉 are you guys gonna try a production deploy?

@roryabraham
Copy link
Contributor

I think so ... pending the 👍 from @trjExpensify

@trjExpensify
Copy link
Contributor

Yep, let's do it! 👍

@Julesssss
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

7 participants