-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy Checklist: Expensify.cash 2021-06-08 #3450
Comments
Starting QA |
Should I check these off #3456 and #3445 and test them when the prod build is deployed? CC @AndrewGable @roryabraham |
Regression is finished
PRs are finished.
Thanks! |
@roryabraham haven't added the DB label yet since there haven't been any changes |
@isagoico I'm investigating why there haven't been any changes here – there have been PRs merged since this was unlocked, which should update this issue. |
Oh y yeah I found it really weird that no changes were disolayed. Let me know when we can start QA. |
Looks like CP's may have broken the normal deploy workflow in an unexpected way – this version-bump PR includes changes that it should not, and has merge conflicts in the normal version-bump files |
Checking off #3512 in the deploy blocker section, we're not going to block on it. |
Okay, staging deploys are fixed now, but I'm going to have to manually update the checklist. It's missing PRs, but I have a PR here that should make it more robust and self-correcting in the future. |
Starting QA |
So @isagoico and I discussed this 1:1 a bit, but I just wanted to make a note of it here. Since Applause is starting QA so late in the day, @isagoico didn't want to guarantee 100% completion. So we aren't going to run a production deploy today, but we still wanted to get a QA cycle in so that we'll know ASAP if there are any new deploy blockers or regressions that need to be addressed. |
Regression is finished.
PRs are finished too:
We were unable to test this PR in iOS because of the attachment issue #3332 (comment) Thanks! |
Resolved #3321 as the fix has been CP'd to staging. |
Hey @roryabraham @isagoico. I think we need to keep the LockCashDeploys label attached to this don't we? Else additional PRs will be included as part of this release and might cause further deployBlockers to occur? |
mmm we usually remove the lock label after finishing regression (which it was finished earlier today) if there are deploy blockers during QA, I actually thought I had removed the label earlier today but looks like I didn't 🤦. On my 1:1 with @roryabraham he mentioned that there was not going to be a production deploy but didn't say anything about the lock label. |
@isagoico, that was my mistake. I think we wanted to leave the lock label to prevent new PRs from being added to the release. Unfortunately we can't undo it at this point, and adding the label back will cause Fortunately, we now have the ability to CP fixes to staging, so once the |
Manually added the following PRs which were missing from this checklist:
Note: @AndrewGable @Jag96 This is something I always have to remember to do. PRs merged while the checklist is locked are not added to the checklist when the lock label is removed (only added to the next checklist if we run a prod deploy). But this PR should fix it, so I would love to merge + test that as soon as possible (after our next prod deploy). |
#3545 was also checked off as we no longer think it needs to block the release. |
Build for
🙏 |
Regression is finished! PRs are finished too Thanks! |
@roryabraham: While re testing the deploy blockers we were able to reproduce this issue: #3536 and #3488 were a pass. For #3543 I'm waiting for someone with iOS to check it since I don't have my iOS on my atm. |
#3543 is still reproducible, reopening the issue. |
Marked #3423 as resolved, as the raised issues were fixed and merged. |
I removed #3215 from being a deployBlocker, as this comment proves it did not introduce the iOS attachment regression. |
@isagoico I am happy to confirm all deployBlockers have been resolved |
That's great news 🎉 are you guys gonna try a production deploy? |
I think so ... pending the 👍 from @trjExpensify |
Yep, let's do it! 👍 |
Release Version:
1.0.68-4
Compare Changes: production...staging
This release contains changes from the following pull requests:
VERSION_CODE
instead ofVERSION
#3445Deploy Blockers:
cc @Expensify/applauseleads
The text was updated successfully, but these errors were encountered: