Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NO QA] Urgent Fix: Missed passing a parameter to NewchatOptions #3517

Merged
merged 2 commits into from
Jun 10, 2021
Merged

[NO QA] Urgent Fix: Missed passing a parameter to NewchatOptions #3517

merged 2 commits into from
Jun 10, 2021

Conversation

parasharrajat
Copy link
Member

cc: @iwiznia

Details

Passed missed parameter to getNewChatOptions.

Credits: @kidroca for pointing it out.

@parasharrajat parasharrajat requested a review from a team as a code owner June 10, 2021 16:48
@MelvinBot MelvinBot requested review from Dal-Papa and removed request for a team June 10, 2021 16:48
@Dal-Papa
Copy link

There seem to be more occurrences of getNewChatOptions that aren't using the boolean, should we put a default instead ? @Julesssss

@parasharrajat
Copy link
Member Author

Done

Dal-Papa
Dal-Papa approved these changes Jun 10, 2021
View reviewed changes
Copy link

@Dal-Papa Dal-Papa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks for the changes.

@parasharrajat
Copy link
Member Author

:shipit: @Dal-Papa

@Dal-Papa Dal-Papa merged commit 655730f into Expensify:main Jun 10, 2021
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.66-13🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@roryabraham roryabraham mentioned this pull request Jun 10, 2021
Closed
49 tasks
@parasharrajat parasharrajat changed the title Urgent Fix: Missed passing a parameter to NewchatOptions [NO QA] Urgent Fix: Missed passing a parameter to NewchatOptions Jun 12, 2021
@Santhosh-Sellavel Santhosh-Sellavel mentioned this pull request Jun 12, 2021
Closed
5 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.68-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@parasharrajat parasharrajat deleted the betas branch November 4, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dal-Papa Dal-Papa Dal-Papa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parasharrajat @Dal-Papa @OSBotify