Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NO QA] Urgent Fix: Missed passing a parameter to NewchatOptions #3517

Merged
merged 2 commits into from
Jun 10, 2021
Merged

[NO QA] Urgent Fix: Missed passing a parameter to NewchatOptions #3517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8abd528
fix: argument order
parasharrajat Jun 10, 2021
4f52861
fix: betas for participant pages
parasharrajat Jun 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/pages/NewChatPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ class NewChatPage extends Component {
props.reports,
props.personalDetails,
'',
false,
props.betas,
);

Expand Down Expand Up @@ -153,6 +154,7 @@ class NewChatPage extends Component {
this.props.reports,
this.props.personalDetails,
searchValue,
false,
this.props.betas,
);
this.setState({
Expand Down
8 changes: 8 additions & 0 deletions src/pages/iou/steps/IOUParticipantsPage/IOUParticipantsRequest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ const personalDetailsPropTypes = PropTypes.shape({
});

const propTypes = {
/** Beta features list */
betas: PropTypes.arrayOf(PropTypes.string).isRequired,

/** Callback to inform parent modal of success */
onStepComplete: PropTypes.func.isRequired,

Expand Down Expand Up @@ -54,6 +57,7 @@ class IOUParticipantsRequest extends Component {
props.personalDetails,
'',
true,
props.betas,
);

this.state = {
Expand Down Expand Up @@ -125,6 +129,7 @@ class IOUParticipantsRequest extends Component {
this.props.personalDetails,
searchValue,
true,
this.props.betas,
);
this.setState({
searchValue,
Expand Down Expand Up @@ -153,5 +158,8 @@ export default compose(
reports: {
key: ONYXKEYS.COLLECTION.REPORT,
},
betas: {
key: ONYXKEYS.BETAS,
},
}),
)(IOUParticipantsRequest);
9 changes: 9 additions & 0 deletions src/pages/iou/steps/IOUParticipantsPage/IOUParticipantsSplit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ const personalDetailsPropTypes = PropTypes.shape({
});

const propTypes = {
/** Beta features list */
betas: PropTypes.arrayOf(PropTypes.string).isRequired,

/** Callback to inform parent modal of success */
onStepComplete: PropTypes.func.isRequired,

Expand Down Expand Up @@ -78,6 +81,7 @@ class IOUParticipantsSplit extends Component {
'',
props.participants,
true,
props.betas,
);

this.state = {
Expand Down Expand Up @@ -178,6 +182,7 @@ class IOUParticipantsSplit extends Component {
isOptionInList ? prevState.searchValue : '',
newSelectedOptions,
true,
this.props.betas,
);
return {
recentReports,
Expand Down Expand Up @@ -213,6 +218,7 @@ class IOUParticipantsSplit extends Component {
searchValue,
[],
true,
this.props.betas,
);
this.setState({
searchValue,
Expand Down Expand Up @@ -253,5 +259,8 @@ export default compose(
reports: {
key: ONYXKEYS.COLLECTION.REPORT,
},
betas: {
key: ONYXKEYS.BETAS,
},
}),
)(IOUParticipantsSplit);