Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tapping the entire IOU preview component open the IOU Details modal #3541

Merged
merged 5 commits into from
Jun 11, 2021

Conversation

jasperhuangg
Copy link
Contributor

@jasperhuangg jasperhuangg commented Jun 11, 2021

NOTE TO REVIEWER: it's better to review it without whitespace changes

Details

See the issue for more context.

Fixed Issues

Fixes #3539

Tests

  1. Create an IOU request.
  2. Tap on the preview.
  3. Verify it opens the IOU details modal.

QA Steps

Same as the above tests

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

android.mp4
desktop.mp4
ios.mp4
mobile.web.mp4
web.mp4

@jasperhuangg jasperhuangg self-assigned this Jun 11, 2021
@jasperhuangg jasperhuangg deleted the jasper-tappableIouDetailsPreview branch June 11, 2021 04:31
@jasperhuangg jasperhuangg restored the jasper-tappableIouDetailsPreview branch June 11, 2021 04:32
@jasperhuangg jasperhuangg reopened this Jun 11, 2021
@jasperhuangg jasperhuangg requested review from a team and removed request for a team June 11, 2021 04:52
@jasperhuangg jasperhuangg marked this pull request as ready for review June 11, 2021 04:52
@jasperhuangg jasperhuangg requested a review from a team as a code owner June 11, 2021 04:52
@MelvinBot MelvinBot requested review from mountiny and nickmurray47 and removed request for a team June 11, 2021 04:52
@jasperhuangg jasperhuangg removed the request for review from nickmurray47 June 11, 2021 05:45
Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works great!

@mountiny mountiny merged commit 3284a15 into main Jun 11, 2021
@mountiny mountiny deleted the jasper-tappableIouDetailsPreview branch June 11, 2021 11:10
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging in version: 1.0.68-0🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.68-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expensify.cash - Make IOU preview component tappable
3 participants