Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use VERSION_CODE instead of VERSION #3445

Merged
merged 3 commits into from
Jun 8, 2021
Merged

Use VERSION_CODE instead of VERSION #3445

merged 3 commits into from
Jun 8, 2021

Conversation

AndrewGable
Copy link
Contributor

Details

Changes the ENV variable to the correct name VERSION_CODE in the platform deploy workflow.

Fixed Issues

Fixes #2918

Tests

  1. Run a production Android deploy
  2. Verify the version_code is not 0

@AndrewGable AndrewGable requested a review from a team as a code owner June 8, 2021 22:00
@AndrewGable AndrewGable self-assigned this Jun 8, 2021
@MelvinBot MelvinBot requested review from jasperhuangg and removed request for a team June 8, 2021 22:00
roryabraham
roryabraham reviewed Jun 8, 2021
View reviewed changes
Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed that in the iOS production lane we're expecting a VERSION input, but in Android we're expecting VERSION_CODE. Maybe we should change the ruby code instead of the GH workflow so that the inputs match better between iOS and Android?

@AndrewGable
Copy link
Contributor Author

👍 - That works! I will make that change.

Jag96
Jag96 approved these changes Jun 8, 2021
View reviewed changes
Copy link
Contributor

@Jag96 Jag96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

roryabraham
roryabraham approved these changes Jun 8, 2021
View reviewed changes
Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, let's see if this works!

@roryabraham roryabraham merged commit bf446b2 into main Jun 8, 2021
@roryabraham roryabraham deleted the andrew-version-code branch June 8, 2021 22:40
@OSBotify
Copy link
Contributor

OSBotify commented Jun 8, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Jun 8, 2021
Closed
49 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Jun 8, 2021

🚀 Deployed to staging in version: 1.0.65-1🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.68-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jag96 Jag96 Jag96 approved these changes

@roryabraham roryabraham roryabraham approved these changes

@jasperhuangg jasperhuangg Awaiting requested review from jasperhuangg

Assignees

@AndrewGable AndrewGable

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Android Production Deploys are failing
4 participants
@AndrewGable @OSBotify @Jag96 @roryabraham