Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IS-3218] Fixed cursor issue #3510

Conversation

aliabbasmalik8
Copy link
Contributor

@aliabbasmalik8 aliabbasmalik8 commented Jun 10, 2021

Details

Fixed Issues

Fixes #3434 (comment)

Tests

QA Steps

  1. Launch the app and log in
  2. Hover over an owned message and click on the edit comment option in the menu
  3. Start editing the message

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

VIDEO: https://recordit.co/QidiIvauZB

Mobile Web

Desktop

VIDEO: http://recordit.co/pyTfs5cFT9

iOS

Screen.Recording.2021-06-10.at.5.38.24.AM.mov

Android

Screenrecorder-2021-06-10-14-15-21-405_0_COMPRESSED.mp4

@aliabbasmalik8 aliabbasmalik8 requested a review from a team as a code owner June 10, 2021 09:39
@MelvinBot MelvinBot requested review from Dal-Papa and removed request for a team June 10, 2021 09:39
@Julesssss
Copy link
Contributor

@aliabbasmalik8 can you please add tests for this PR please?

Copy link
Contributor

@Julesssss Julesssss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well for me on Android (the platform that the crash occurred on)

@Julesssss
Copy link
Contributor

All yours @Dal-Papa

@Dal-Papa Dal-Papa merged commit 192b06d into Expensify:main Jun 10, 2021
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.66-13🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@kavimuru kavimuru added the DeployBlockerCash This issue or pull request should block deployment label Jun 10, 2021
@kavimuru
Copy link

Tapping on Edit Message scrolls down to the bottom to the compose box

Expected result:

User stays in the same position and is able to edit the message

Actual result:

Tapping on Edit scrolls down the page to the compose box

Actions Performed:

  1. Launch the app and log in
  2. Hover over a sent message and click on the edit comment option in the menu
  3. Start editing the message

Platform:

iOS
mWeb
Android ✔️

Build:

1.0.67-0

Notes/Images/Video:

Bug5107427_Screen_Recording_20210610-190557_Expensifycash.mp4

@aliabbasmalik8
Copy link
Contributor Author

aliabbasmalik8 commented Jun 11, 2021

@kavimuru
I believe this issue not due to my PR and not relate to my working issue.
it's a NEW ISSUE and I tested it on android without my commits and still produce.

and it's due to when the keyboard opens then messages scroll to the bottom.
would like to fix it but for the new issue, there is a proposal approval procedure.
Thanks

@isagoico
Copy link

Separate issue here #3545

@Julesssss
Copy link
Contributor

Yeah, this seems to be caused by another issue. I tested this branch in isolation and can't reproduce.

@Julesssss
Copy link
Contributor

@isagoico should we remove the deployBlocker label, as it's being handled on that linked issue?

@isagoico
Copy link

Oh woops yeah, I think we should remove if the linked issue has the label already. Thanks @Julesssss 🙇‍♀️

@isagoico isagoico removed the DeployBlockerCash This issue or pull request should block deployment label Jun 11, 2021
@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.68-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@luacmartins luacmartins mentioned this pull request Sep 15, 2022
93 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants