-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IS-3218] Fixed cursor issue #3510
[IS-3218] Fixed cursor issue #3510
Conversation
@aliabbasmalik8 can you please add tests for this PR please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well for me on Android (the platform that the crash occurred on)
All yours @Dal-Papa |
🚀 Deployed to staging in version: 1.0.66-13🚀
|
Tapping on Edit Message scrolls down to the bottom to the compose boxExpected result:User stays in the same position and is able to edit the message Actual result:Tapping on Edit scrolls down the page to the compose box Actions Performed:
Platform:iOS Build:1.0.67-0 Notes/Images/Video:Bug5107427_Screen_Recording_20210610-190557_Expensifycash.mp4 |
@kavimuru and it's due to when the keyboard opens then messages scroll to the bottom. |
Separate issue here #3545 |
Yeah, this seems to be caused by another issue. I tested this branch in isolation and can't reproduce. |
@isagoico should we remove the deployBlocker label, as it's being handled on that linked issue? |
Oh woops yeah, I think we should remove if the linked issue has the label already. Thanks @Julesssss 🙇♀️ |
🚀 Deployed to production in version: 1.0.68-4🚀
|
Details
Fixed Issues
Fixes #3434 (comment)
Tests
QA Steps
Tested On
Screenshots
Web
VIDEO: https://recordit.co/QidiIvauZB
Mobile Web
Desktop
VIDEO: http://recordit.co/pyTfs5cFT9
iOS
Screen.Recording.2021-06-10.at.5.38.24.AM.mov
Android
Screenrecorder-2021-06-10-14-15-21-405_0_COMPRESSED.mp4