Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Add committer name #3529

Merged
merged 1 commit into from
Jun 10, 2021
Merged

[No QA] Add committer name #3529

merged 1 commit into from
Jun 10, 2021

Conversation

roryabraham
Copy link
Contributor

Details

Forgot to register committer name before creating commits with the git cli

Fixed Issues

Fixes failed workflow run: https://github.com/Expensify/Expensify.cash/runs/2797711700?check_suite_focus=true

Tests

Merge-to-test

Tested On

GitHub only

@roryabraham roryabraham requested a review from Jag96 June 10, 2021 21:32
@roryabraham roryabraham self-assigned this Jun 10, 2021
@roryabraham roryabraham requested a review from a team as a code owner June 10, 2021 21:32
@MelvinBot MelvinBot requested review from NikkiWines and removed request for a team June 10, 2021 21:32
@Jag96
Copy link
Contributor

Jag96 commented Jun 10, 2021

Skipping unnecessary tests to fix an issue preventing CPs

@Jag96 Jag96 merged commit b2f30c6 into main Jun 10, 2021
@Jag96 Jag96 deleted the Rory-AddCommiterName branch June 10, 2021 21:33
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.66-13🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@roryabraham roryabraham changed the title Add committer name [No QA] Add committer name Jun 10, 2021
@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.68-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants