-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web - IOU - Previously used currency appears for a brief moment for request/ split money #3560
Comments
Triggered auto assignment to @HorusGoul ( |
Issue reproducible today during KI retests |
I think the fix here would be to show the loading icon while we retrieve currency. The |
@Julesssss Just tried to do that, but the We could fix this by returning a promise from the |
Yeah, we reuse the iou.loading key in a few places to avoid duplication, but the IOU Modal is the right place for this IMO. Alternatively we could have a new key/pair under the key: As for managing state, we prefer to drive everything from Onyx, hence the above keys. Here's some additional context: https://expensify.slack.com/archives/C01GTK53T8Q/p1623064998057400 |
The other problem is that functions that occur within the 'Action' files, should not return anything. Components should act upon data from Onyx only -- our offline-first architecture. |
I see! I was able to get it to work using Onyx: Screen.Recording.2021-06-14.at.13.10.44.movI'll open a PR with the fix. Thanks for the guidance, @Julesssss! 😊 |
Nice, that looks ideal! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Expected Result:
Regardless of the previously selected currency, the currency should match user's IP location
Actual Result:
Previously selected currency flashes for a brief moment, then currency of user's IP location appears
Action Performed:
Workaround:
Unknown
Platform:
Where is this issue occurring?
Web ✔️
iOS ✔️
Android ✔️
Desktop App ✔️
Mobile Web ✔️
Version Number: 1.0.68-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Bug5109090_Recording__82.mp4
Expensify/Expensify Issue URL:
View all open jobs on Upwork
The text was updated successfully, but these errors were encountered: