Display full-screen loading indicator while fetching currency data #3577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MelvinBot
requested review from
Gonals
and removed request for
a team and
Gonals
Julesssss
requested changes
Jun 15, 2021
There was a problem hiding this comment.
This looks good, but I think the IOU key is better suited for this loading state. MY_PERSONAL_DETAILS should contain user information, not state related to an unrelated API call.
Can you swap this to the IOU key? As its purpose is to contain the loading states for IOU features.
|
Also, we should initialise state keys here, so that we can guarantee they exist. |
|
Done! |
Julesssss
reviewed
Jun 15, 2021
Julesssss
approved these changes
Jun 18, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging in version: 1.0.71-1🚀
|
|
🚀 Deployed to production in version: 1.0.73-3🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Display full-screen loading indicator while fetching currency data to avoid flashing the previous currency in the Request money dialog.
Fixed Issues
Fixes #3560
Tests
QA Steps
Tested On
Screenshots
Web
Screen.Recording.2021-06-14.at.13.10.44.mov
Mobile Web
Screen.Recording.2021-06-14.at.13.53.12.mov
Desktop
Screen.Recording.2021-06-14.at.13.56.55.mov
iOS
Screen.Recording.2021-06-14.at.14.06.37.mov
Android
Screen.Recording.2021-06-14.at.14.10.10.mov