Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3102 add es translation for close #3525

Merged

Conversation

dklymenk
Copy link
Contributor

This is a minor translation addition for Spanish. In my previous MR I have missed it, and it has been requested by @iwiznia here.

Details

Add Spanish translation for "Close" message.

@dklymenk dklymenk requested a review from a team as a code owner June 10, 2021 20:59
@MelvinBot MelvinBot requested review from Luke9389 and removed request for a team June 10, 2021 20:59
iwiznia
iwiznia previously approved these changes Jun 10, 2021
Luke9389
Luke9389 previously approved these changes Jun 11, 2021
Copy link
Contributor

@Luke9389 Luke9389 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Once the merge conflict is resolved we can merge. Please feel free to reach out for help with that if needed. Thanks!

@dklymenk dklymenk dismissed stale reviews from Luke9389 and iwiznia via 0984c69 June 11, 2021 16:10
@dklymenk
Copy link
Contributor Author

@Luke9389 Resolved the conflict

@Luke9389 Luke9389 merged commit bcd533b into Expensify:main Jun 11, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging in version: 1.0.68-0🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.68-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants