Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression with default option selection #3426

Merged
merged 1 commit into from
Jun 9, 2021

Conversation

robertjchen
Copy link
Contributor

Details

Thanks for the review! This PR addresses a regression with intended behavior, where pressing return while in the search box (for finding/selecting a group member) should select the first result being displayed without requiring the user to manually click the search result.

Fixed Issues

Fixes #3379

Tests

Applicable to only the Browser and Desktop app:

  1. Log in to e.cash app
  2. Click on the FAB button on the bottom left (+ button)
  3. Click on New Group
  4. Search for group members such that only one result is showing
  5. Pressing the Up and Down arrow keys shouldn't select any result entries on the list
  6. Pressing return at that point should select the sole group member that is being displayed.

QA Steps

Applicable to only the Web and Desktop app:

  1. Log in to e.cash app
  2. Click on the FAB button on the bottom left (+ button)
  3. Click on New Group
  4. Search for group members such that only one result is showing
  5. Pressing return at that point should select that group member and clear the input field for search/selection of another group member

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Not applicable on the other platforms.

Screenshots

Web / Desktop

Screen Shot 2021-06-08 at 8 39 43 PM

Screen Shot 2021-06-08 at 8 39 50 PM

Mobile Web

N/A

iOS

N/A

Android

N/A

@robertjchen robertjchen requested a review from a team June 8, 2021 12:59
@robertjchen robertjchen self-assigned this Jun 8, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@MelvinBot MelvinBot requested review from MonilBhavsar and removed request for a team June 8, 2021 13:00
@robertjchen
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@robertjchen
Copy link
Contributor Author

recheck

@MonilBhavsar MonilBhavsar merged commit 8fdf7cb into main Jun 9, 2021
@MonilBhavsar MonilBhavsar deleted the robert-fixDefaultGroupSelection branch June 9, 2021 08:46
@OSBotify
Copy link
Contributor

OSBotify commented Jun 9, 2021

🚀 Deployed to staging in version: 1.0.65-8🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.68-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group chat - Allow pressing return to add group member when there's only 1 search match result
3 participants