Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS - Plus green button isn't announced via Voiceover #3415

Merged
merged 2 commits into from
Jun 9, 2021
Merged

iOS - Plus green button isn't announced via Voiceover #3415

merged 2 commits into from
Jun 9, 2021

Conversation

TwizzyIndy
Copy link
Contributor

@TwizzyIndy TwizzyIndy commented Jun 8, 2021

@AndrewGable

Details

After made changes with PR #3285 , New Chat (Floating Action) button can't pronounce with VoiceOver on iOS. So I made this PR to fix this issue.

Fixed Issues

Fixes #3101 , #3285 (comment)

Tests, QA Steps

  1. Launch the app/webapp
    Prerequisite: Turn ON the Screen reader / VoiceOver.
  2. Mobile: Navigate using Swipe gesture(From Left to Right) and verily.
    Web: Navigate the page using arrow keys then verify.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Screen.Recording.2021-06-05.at.10.10.28_480p.mov

@TwizzyIndy TwizzyIndy requested a review from a team as a code owner June 8, 2021 05:05
@MelvinBot MelvinBot requested review from Gonals and removed request for a team June 8, 2021 05:06
@Gonals Gonals merged commit 5784b79 into Expensify:main Jun 9, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Jun 9, 2021

🚀 Deployed to staging in version: 1.0.65-6🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.68-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility improvement: Role and label missing for Search, My Settings, and New Chat (Floating Action)
4 participants