Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename AddBankAccountPage to AddPersonalBankAccountPage #3443

Merged
merged 1 commit into from
Jun 8, 2021

Conversation

marcaaron
Copy link
Contributor

Details

  • Since we are adding a new flow for adding a "verified" bank account to E.cash we'll want to differentiate between the modal that adds a personal bank account and the one that adds business bank account.
  • Adds a minor copy change to match new mockups

Fixed Issues

No Issue Prep for N5.5

Tests

  1. Navigate to /add-personal-bank-account
  2. Verify the "Add Bank Account" right side panel opens

QA Steps

No QA - as this flow isn't used by anything yet

Tested On

  • Web

Skipping the other platforms as the changes are just in name so web is enough to prove things worked IMO.

Screenshots

Web

2021-06-08_10-40-04
2021-06-08_10-40-06

@marcaaron marcaaron self-assigned this Jun 8, 2021
@marcaaron marcaaron requested a review from a team as a code owner June 8, 2021 20:41
@MelvinBot MelvinBot requested review from nickmurray47 and tgolen and removed request for a team June 8, 2021 20:41
@marcaaron
Copy link
Contributor Author

@nickmurray47 @tgolen no need to review this one PullerBear is got trigger happy

Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and passed testing 👍

@roryabraham roryabraham merged commit 3683d39 into main Jun 8, 2021
@roryabraham roryabraham deleted the marcaaron-renamePersonalBankAccount branch June 8, 2021 21:52
@OSBotify
Copy link
Contributor

OSBotify commented Jun 8, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Jun 8, 2021

🚀 Deployed to staging in version: 1.0.65-1🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.68-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants