Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File upload failure checking #3332

Merged
merged 2 commits into from
Jun 10, 2021
Merged

File upload failure checking #3332

merged 2 commits into from
Jun 10, 2021

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Jun 3, 2021 •
edited
Loading

Details

Fixed Issues

Fixes #2712

Tests | QA Steps

  1. Open any conversation on E.cash.
  2. Now try to send a video that is not supported. For example any mkv file.
  3. you should see an error message that the file is not supported and the sending message should be removed from the List.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

video-fail.mp4

Mobile Web

1622692926206.mp4

Desktop

iOS

Android

1622692141097.mp4

@parasharrajat parasharrajat marked this pull request as ready for review June 3, 2021 02:16
@parasharrajat parasharrajat requested a review from a team as a code owner June 3, 2021 02:16
@MelvinBot MelvinBot requested review from ctkochan22 and removed request for a team June 3, 2021 02:16
@parasharrajat parasharrajat changed the title File upload failure checking [WIP]File upload failure checking Jun 3, 2021
@parasharrajat parasharrajat changed the title [WIP]File upload failure checking File upload failure checking Jun 4, 2021
@parasharrajat
Copy link
Member Author

Ready for review. Thanks.

@parasharrajat
Copy link
Member Author

@ctkochan22 :shipit:

@parasharrajat
Copy link
Member Author

Is there anything left that is preventing it from being merged?

@ctkochan22
Copy link
Contributor

Was waiting on @iwiznia but small change. Looks fine.

@ctkochan22 ctkochan22 merged commit 92429b5 into Expensify:main Jun 10, 2021
@iwiznia
Copy link
Contributor

iwiznia commented Jun 10, 2021

Oh sorry, I was not a reviewer, just got pinged to answer a question.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.66-13🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@roryabraham roryabraham mentioned this pull request Jun 10, 2021
Closed
49 tasks
@isagoico
Copy link

@parasharrajat @ctkochan22 Anything that needs to be QAd here?

@parasharrajat
Copy link
Member Author

Oh yeah @isagoico Updating steps.

@parasharrajat
Copy link
Member Author

Done

@isagoico
Copy link

We were unable to test this PR in iOS because of this issue #3543. All other environments (Android, Desktop and Web) were a pass.

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.68-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@parasharrajat parasharrajat deleted the video-fail branch November 20, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwiznia iwiznia iwiznia left review comments

@ctkochan22 ctkochan22 ctkochan22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PAY on 6/17] Uploading a video fails.
5 participants
@parasharrajat @ctkochan22 @iwiznia @OSBotify @isagoico