-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hold - To be deployed with new.expensify.com changes] Scrubbing Expensify Cash for New Expensify #3984
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
recheck |
@trjExpensify can you give it another looksie? I've applied your feedback, and am going to now work on updating all the icons. |
Ah, I'm not positive, but I don't think I'll need to change the icons after all. The text is ready for review! |
@kevinksullivan, I've added you as a reviewer for max timezone coverage. 👍 |
Dope, thanks @johncschuster! Are we going to pop the merge on hold for the migration and repo rename? @kevinksullivan is keeping on top of that one with Mitch out, I believe. |
@trjExpensify Yep! I'll put it on hold and make sure it's linked up to the other PRs appropriately. Thanks for the review! |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging in version: 1.0.78-3🚀
|
🚀 Deployed to production in version: 1.0.79-4🚀
|
Details
Updating Contributing.md and Readme.md - removing
Expensify.cash
and replacing it withNew Expensify
,Expensify
, orthe app
where appropriate.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/162036
Tests
None.
QA Steps
None, really. Just read through the doc to see if there any instances of 'Cash' that I missed.