Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hold - To be deployed with new.expensify.com changes] Scrubbing Expensify Cash for New Expensify #3984

Merged
merged 3 commits into from
Jul 15, 2021

Conversation

johncschuster
Copy link
Contributor

@johncschuster johncschuster commented Jul 12, 2021

Details

Updating Contributing.md and Readme.md - removing Expensify.cash and replacing it with New Expensify, Expensify, or the app where appropriate.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/162036

Tests

None.

QA Steps

None, really. Just read through the doc to see if there any instances of 'Cash' that I missed.

@johncschuster johncschuster requested a review from a team as a code owner July 12, 2021 17:24
@MelvinBot MelvinBot requested review from ctkochan22 and removed request for a team July 12, 2021 17:24
@github-actions
Copy link
Contributor

github-actions bot commented Jul 12, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@johncschuster
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@johncschuster
Copy link
Contributor Author

recheck

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@johncschuster johncschuster marked this pull request as draft July 13, 2021 13:20
@johncschuster
Copy link
Contributor Author

@trjExpensify can you give it another looksie? I've applied your feedback, and am going to now work on updating all the icons.

@johncschuster
Copy link
Contributor Author

Ah, I'm not positive, but I don't think I'll need to change the icons after all. The text is ready for review!

@johncschuster johncschuster marked this pull request as ready for review July 13, 2021 16:23
@johncschuster johncschuster requested review from kevinksullivan and removed request for ctkochan22 July 13, 2021 16:32
@johncschuster
Copy link
Contributor Author

@kevinksullivan, I've added you as a reviewer for max timezone coverage. 👍

@trjExpensify
Copy link
Contributor

Dope, thanks @johncschuster! Are we going to pop the merge on hold for the migration and repo rename? @kevinksullivan is keeping on top of that one with Mitch out, I believe.

@johncschuster
Copy link
Contributor Author

@trjExpensify Yep! I'll put it on hold and make sure it's linked up to the other PRs appropriately. Thanks for the review!

@johncschuster johncschuster changed the title Scrubbing Expensify Cash for New Expensify [Hold - To be deployed with new.expensify.com changes] Scrubbing Expensify Cash for New Expensify Jul 13, 2021
@johncschuster johncschuster merged commit 329dc18 into main Jul 15, 2021
@johncschuster johncschuster deleted the JohnSchusterECashDocEdits branch July 15, 2021 13:57
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.78-3🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.79-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants