Give disabled buttons the disabled cursor style #3992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
95 tasks
|
🚀 Deployed to staging in version: 1.0.78-3🚀
|
|
🚀 Deployed to production in version: 1.0.79-4🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Was looking at this old PR and noticed that this detail slipped through the cracks. It's a tiny update that I think provides a better UX in general.
Basically just give disabled buttons this cursor style on hover:
Fixed Issues
$ n/a
Tests / QA Steps
Hover over any disabled button in the app. It should have the "not-allowed" cursor style.
Tested On
Screenshots
Web
DisabledButtonWeb.mov
Mobile Web
n/a
Desktop
DisabledButtonDesktop.mov
iOS
n/a
Android
n/a