Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to Concierge on Validation screen when bank account is verifying #3967

Merged
merged 6 commits into from
Jul 13, 2021

Conversation

marcaaron
Copy link
Contributor

@marcaaron marcaaron commented Jul 10, 2021

Details

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/170032

Tests

  1. Create a new account on a private domain + validate it
  2. Create a new chat with a random user and make sure you are navigated to that chat
  3. Create a workspace on this account via Expensify.cash green floating button (create menu)
  4. Navigate to the workspace page and tap Get Started
  5. Verify the Add Bank Account modal appears and follow instructions here to create a VERIFYING bank account. This means we'll want to add all the information for the PENDING instructions and once we get to the Requestor Information step we'll skip adding Alberta Charleson and use something bogus instead that will need to be manually verified.
  6. Keep submitting information until you get to the Validate step (A warning will appear. This is normal and we should submit again.)
  7. Go through the Onfido flow
  8. Select that you own more than 25% in the Beneficial Owners step and add no additional owners
  9. Verify that you now see an animation + copy with a link to your chat with Concierge
  10. Tap this link and verify you are brought to your chat with Concierge
  11. Navigate back to your workspace page and verify you now see Finish Setup for the button
  12. Tap this button and verify you are brought back to the Validate step

QA Steps

Internal / TBD - I think we can just use the same steps as above
(or whatever information will lead to an account needing to be manually verified by ops)

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

2021-07-12_12-11-48
2021-07-12_12-27-22
2021-07-12_12-33-40
2021-07-12_12-36-16

Mobile Web

2021-07-12_13-29-45
2021-07-12_13-29-51

Desktop

2021-07-12_14-37-33
2021-07-12_14-37-39

iOS

2021-07-12_13-34-46
2021-07-12_13-34-38

Android

2021-07-12_14-34-46
2021-07-12_14-34-35

@marcaaron marcaaron self-assigned this Jul 10, 2021
@marcaaron marcaaron changed the title [WIP] Add link to Concierge on Validation screen when bank account is verifying Add link to Concierge on Validation screen when bank account is verifying Jul 12, 2021
@marcaaron
Copy link
Contributor Author

Still working on screen shots for other platforms but going to kick off reviews.

@marcaaron marcaaron marked this pull request as ready for review July 12, 2021 23:11
@marcaaron marcaaron requested a review from a team as a code owner July 12, 2021 23:11
@MelvinBot MelvinBot requested review from jasperhuangg and removed request for a team July 12, 2021 23:11
@marcaaron
Copy link
Contributor Author

Tested on all platforms. Ready for review 🙏

Comment on lines +173 to +174
Navigation.dismissModal();
Navigation.dismissModal();
Copy link
Contributor

@jasperhuangg jasperhuangg Jul 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NAB: Should we maybe write up some sort of navigation utility that just dismisses all modals?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually think it's a good point because I don't like this this double dismiss logic, but I'm not sure I'll get to it right now.
Would you be willing to create an issue for that so we can look into improving it soon?

Copy link
Contributor

@jasperhuangg jasperhuangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left a NAB comment, if you don't think it needs addressing feel free to self-merge!

@marcaaron marcaaron merged commit 874df3f into main Jul 13, 2021
@marcaaron marcaaron deleted the marcaaron-navigateToValidationStep branch July 13, 2021 17:43
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.77-6🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.79-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants