-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add link to Concierge on Validation screen when bank account is verifying #3967
Conversation
Still working on screen shots for other platforms but going to kick off reviews. |
Tested on all platforms. Ready for review 🙏 |
Navigation.dismissModal(); | ||
Navigation.dismissModal(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NAB: Should we maybe write up some sort of navigation utility that just dismisses all modals?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually think it's a good point because I don't like this this double dismiss logic, but I'm not sure I'll get to it right now.
Would you be willing to create an issue for that so we can look into improving it soon?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Left a NAB comment, if you don't think it needs addressing feel free to self-merge!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging in version: 1.0.77-6🚀
|
🚀 Deployed to production in version: 1.0.79-4🚀
|
Details
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/170032
Tests
Get Started
Add Bank Account
modal appears and follow instructions here to create aVERIFYING
bank account. This means we'll want to add all the information for thePENDING
instructions and once we get to theRequestor Information
step we'll skip addingAlberta Charleson
and use something bogus instead that will need to be manually verified.Validate
step (A warning will appear. This is normal and we should submit again.)Beneficial Owners
step and add no additional ownersFinish Setup
for the buttonValidate
stepQA Steps
Internal / TBD - I think we can just use the same steps as above
(or whatever information will lead to an account needing to be manually verified by ops)
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android