-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Tooltip and message date position #3864
Conversation
@rdjuric in the future, with regressions, feel free to continue to tag and request reviews from engineers that are connected to the original issue |
linking this to the original issue: #3172 |
Update made @Luke9389! Changed our |
Made a few changes after your comments @parasharrajat. Thanks! |
Updated @Luke9389 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few more small things
Updated @Luke9389 |
OK, this is lookin' good. Can you be sure to retest on all 5 platforms with the most recent version of the code before we wrap this up? |
Will start retesting and tag you here once it's done! |
Thanks! (I know it's a pain but I've seen looooots of regressions caused by skipping this final step) |
I tested this branch and the PR worked correctly. I merged it into our main branch locally just to make sure things were okay and looks like this commit 7729fc0 had a regression - it nullified the styling changes we made on the previous PR #3830. That's why we have this Tooltip/message date bug on prod (where the avatar and the display name aren't wrapped in the To make our change work with the I kept our |
OK, that sounds fine to me 👍 |
Can we merge this? @Luke9389 |
was just testing on all platforms myself as well :) |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Thanks, @Luke9389! Sorry for missing this regression on the first PR. |
🚀 Deployed to staging in version: 1.0.77-6🚀
|
🚀 Deployed to production in version: 1.0.79-4🚀
|
Details
Fixed Issues
Fixes an issue with the below PR where the Tooltip and the Timestamp of a message would me misplaced.
$ PR #3830
Tests
QA Steps
Same as above.
Tested On
Screenshots
Web
web.mov
Mobile Web
mWeb.mp4
Desktop
desktop.mov
iOS
iOS.mp4
Android
video.mp4