Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - Message dates are displayed under user name #3939

Closed
mvtglobally opened this issue Jul 9, 2021 · 10 comments
Closed

Web - Message dates are displayed under user name #3939

mvtglobally opened this issue Jul 9, 2021 · 10 comments
Assignees
Labels
Daily KSv2 Engineering Reviewing Has a PR in review

Comments

@mvtglobally
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to https://staging.expensify.cash
  2. Log in with any account
  3. Go to any conversation and check the dates of your conversation.

Expected Result:

Message dates are displayed next to the user name

Actual Result:

Message dates are displayed under user name

Workaround:

N/A

Platform:

Where is this issue occurring?

Web ✔️
iOS
Android
Desktop App
Mobile Web

Version Number: Build: 1.0.76-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Is the issue reproducible in Prod: No
OS and browser used: Chrome

View all open jobs on Upwork

@mvtglobally mvtglobally added DeployBlockerCash This issue or pull request should block deployment AutoAssignerTriage Auto assign issues for triage to an available triage team member Engineering labels Jul 9, 2021
@MelvinBot
Copy link

Triggered auto assignment to @conorpendergrast (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot
Copy link

Triggered auto assignment to @luacmartins (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Jul 9, 2021
@github-actions github-actions bot added the Hourly KSv2 label Jul 9, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Jul 9, 2021

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@parasharrajat
Copy link
Member

parasharrajat commented Jul 9, 2021

Regression via #3830 (comment).

Any there is more the issue. The tooltip over the names is misplaced.

@rdjuric
Copy link
Contributor

rdjuric commented Jul 9, 2021

Yes, PR to fix this is under review #3864

@Jag96
Copy link
Contributor

Jag96 commented Jul 9, 2021

PR to fix the regression is already under review and the app still functions, removing Deploy Blocker

@Jag96 Jag96 removed the DeployBlockerCash This issue or pull request should block deployment label Jul 9, 2021
@Jag96 Jag96 added Daily KSv2 Reviewing Has a PR in review and removed Hourly KSv2 labels Jul 9, 2021
@conorpendergrast conorpendergrast removed their assignment Jul 9, 2021
@conorpendergrast
Copy link
Contributor

Unassigning myself as this has already been well-triaged (and I agree it's an issue to fix!)

@luacmartins
Copy link
Contributor

Unassigning myself as this is already being taken care of.

@luacmartins luacmartins removed their assignment Jul 9, 2021
@isagoico
Copy link

Issue not reproducible during KI retests (First Week)

@parasharrajat
Copy link
Member

This can be closed PR is merged.

@Jag96 Jag96 closed this as completed Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

9 participants