Revert suppression of touchstart to fix regressions #3816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This PR needs to be merged ASAP. There are more than 4 regressions. |
tylerkaraszewski
approved these changes
Jun 30, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Jun 30, 2021
Revert suppression of touchstart to fix regressions (cherry picked from commit af376d2)
This was referenced Jun 30, 2021
|
🚀 Cherry-picked to staging in version: 1.0.75-2🚀
|
This was referenced Jul 7, 2021
95 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Partially reverts https://github.com/Expensify/Expensify.cash/pull/3659/files, particularly this commit to fix two major regressions (my fault for not noticing during my testing).
Fixed Issues
$ #3806
Tests / QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android