Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mWeb - Chat - "View details" in chat is not responding #3826

Closed
kavimuru opened this issue Jun 30, 2021 · 9 comments
Closed

mWeb - Chat - "View details" in chat is not responding #3826

kavimuru opened this issue Jun 30, 2021 · 9 comments
Assignees
Labels
Daily KSv2 DeployBlockerCash This issue or pull request should block deployment Engineering External Added to denote the issue can be worked on by a contributor

Comments

@kavimuru
Copy link

kavimuru commented Jun 30, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to https://staging.expensify.cash
  2. Log in with any user
  3. Find the user where you have requested money and select the user.
  4. Find the "view details" in the conversation and click on it

Expected Result:

"View details" should open and I will be able to see all details

Actual Result:

"View details" isn't responding

Workaround:

Unknown

Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web ✔️

Version Number: 1.0.75-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug5133868_Image_from_iOS__4_
https://user-images.githubusercontent.com/43996225/124005277-e08bf800-d9a6-11eb-9d08-a21d858ff81d.mp4

Expensify/Expensify Issue URL:

View all open jobs on Upwork

@MelvinBot
Copy link

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@parasharrajat
Copy link
Member

Regression from #3659.

@kavimuru kavimuru added DeployBlockerCash This issue or pull request should block deployment and removed Daily KSv2 Engineering labels Jun 30, 2021
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@bondydaa bondydaa removed their assignment Jun 30, 2021
@bondydaa bondydaa added the External Added to denote the issue can be worked on by a contributor label Jun 30, 2021
@MelvinBot
Copy link

Triggered auto assignment to @michaelhaxhiu (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@MelvinBot MelvinBot added the Daily KSv2 label Jun 30, 2021
@bondydaa bondydaa removed the Hourly KSv2 label Jun 30, 2021
@parasharrajat
Copy link
Member

This is fixed

@bondydaa
Copy link
Contributor

the external on here since it seems that this is already being handled.

This is from #3659, which is being reverted on #3816.

Viacheslav80 has said they will fix it in a follow up PR so I think we just need to make sure it gets back assigned to them?

@bondydaa
Copy link
Contributor

oh thanks @parasharrajat! can you link us to which PR ended up fixing this? I'm not 100% on the protocol here.

@parasharrajat
Copy link
Member

#3816. This revert PR fixed it.

@michaelhaxhiu
Copy link
Contributor

Cool, should we close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 DeployBlockerCash This issue or pull request should block deployment Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

6 participants