Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Use onLayout to record chat switching time #4140

Merged
merged 2 commits into from
Jul 20, 2021
Merged

Conversation

marcaaron
Copy link
Contributor

Details

The way we were recording chat switching times seems prone to error and this PR simplifies things.

Fixed Issues

$ #3889

Tests

  1. Switch from one chat to another
  2. Verify that the log appears at about the same time the chat renders on screen like so...
 DEBUG  Timing:expensify.cash.switch_report.cold 1651

QA Steps

No QA

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@marcaaron marcaaron self-assigned this Jul 19, 2021
@marcaaron marcaaron requested a review from a team as a code owner July 19, 2021 21:08
@MelvinBot MelvinBot requested review from iwiznia and removed request for a team July 19, 2021 21:08
@iwiznia iwiznia merged commit 6ba320d into main Jul 20, 2021
@iwiznia iwiznia deleted the marcaaron-useOnLayout branch July 20, 2021 09:56
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 20, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.79-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.80-2🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants