[HOLD] Apply changes from main directly to staging #4083
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is targetted specifically to the |
tgolen
changed the title
|
Putting a hold on this until we decide exactly how we want to fix this. |
|
Hmmm I don't think we should merge this ... I am not 100% sure but I'm worried that there might be some unexpected side-effects that could break the CD. Let's start by just running a normal staging deploy (i.e: deploy |
|
Sounds good. I'll just close this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
It seems like the last staging deploy had a glitch in it and some of these changes weren't applied. All I did was copy the contents of
WorkspaceInvitePage.jsfrommain.Fixed Issues
$ #4060
Tests
QA Steps
Same as above
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android