Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix display of report typing indicator and participant local time #4020

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

roryabraham
Copy link
Contributor

@roryabraham roryabraham commented Jul 13, 2021

Details

Fixes the style of the report typing indicator and participant local time. Context here

Fixed Issues

$ #3965

Tests / QA Steps

  1. Log into E.cash on one device/window in one account, and another account in another device/window.
  2. Open a chat report between the two accounts. Start typing in one, and verify that the report typing indicator appears for the other user. The username in the report typing indicator should be bold, grey, and the same size as the rest of the text. It should not be cut-off at all.
  3. Go to Settings -> Profile and change the timezone of one of the users.
  4. Open the chat report between the two accounts. The timezone of the other user should be shown above the main ReportActionCompose (you might have to refresh the page). The time and username should be bold, grey, and the same size as the rest of the text. The rest of the text should not be bold.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image

Mobile Web

image

Desktop

image

iOS

image

Android

(sorry ignore this warning that pops up 100% of the time running the android app on dev)

image

@roryabraham roryabraham self-assigned this Jul 13, 2021
@OSBotify
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@roryabraham roryabraham marked this pull request as ready for review July 13, 2021 23:24
@roryabraham roryabraham requested a review from a team as a code owner July 13, 2021 23:24
@MelvinBot MelvinBot requested review from Beamanator and removed request for a team July 13, 2021 23:24
@Beamanator
Copy link
Contributor

I was able to reproduce before, but with your fixes I think everything's looking great 👍 screenshots to prove:

iOS Android
Screen Shot 2021-07-14 at 2 10 16 PM Screen Shot 2021-07-14 at 2 18 05 PM
iOS mWeb
Screen Shot 2021-07-14 at 2 21 00 PM

Copy link
Contributor

@Beamanator Beamanator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍 - see screenshots for my tests that passed

@Beamanator Beamanator merged commit 0639c67 into main Jul 14, 2021
@Beamanator Beamanator deleted the Rory-FixUserTypingIndicator branch July 14, 2021 12:26
github-actions bot pushed a commit that referenced this pull request Jul 14, 2021
Fix display of report typing indicator and participant local time

(cherry picked from commit 0639c67)
roryabraham added a commit that referenced this pull request Jul 14, 2021
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging in version: 1.0.77-3🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.77-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.77-6🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.79-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants