Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS - Chat - Text "is typing" is slightly cut off at the bottom #3965

Closed
kavimuru opened this issue Jul 9, 2021 · 19 comments
Closed

iOS - Chat - Text "is typing" is slightly cut off at the bottom #3965

kavimuru opened this issue Jul 9, 2021 · 19 comments
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@kavimuru
Copy link

kavimuru commented Jul 9, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open app and login
  2. As account B, type in the text box and immediately check the account A device
  3. Verify there's a message indicated that user B is typing

Expected Result:

"Is typing" is not cut off

Actual Result:

"Is typing" cut off at the bottom

Workaround:

Visual

Platform:

Where is this issue occurring?

Web
iOS ✔️
Android
Desktop App
Mobile Web

Version Number:
1.0.77-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:

View all open jobs on Upwork

@MelvinBot
Copy link

Triggered auto assignment to @Beamanator (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@isagoico
Copy link

Adding the deploy blocker label since this is not reproducible in Build 1.0.76-2

@isagoico isagoico added the DeployBlockerCash This issue or pull request should block deployment label Jul 11, 2021
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@github-actions github-actions bot added Hourly KSv2 and removed Daily KSv2 labels Jul 11, 2021
@roryabraham
Copy link
Contributor

There's a good likelihood that this might be fixed by #3966 as well.

@isagoico
Copy link

isagoico commented Jul 13, 2021

Issue is still reproducible both on Android and iOS

@parasharrajat
Copy link
Member

Ok. It seems that I may have caused this. I will look into it today.

@parasharrajat
Copy link
Member

Can't reproduce it on android

@isagoico
Copy link

isagoico commented Jul 13, 2021

It's still repro on my side. Here's a closer looks on how it looks in my Android device
image

@parasharrajat
Copy link
Member

Ok I will try different devices.

@Beamanator
Copy link
Contributor

Beamanator commented Jul 13, 2021

@roryabraham I'm still seeing this in main so I don't think your PR fixed it; @parasharrajat I reproduced the issue (barely) on Android here:

android iOS
Screen Shot 2021-07-13 at 4 20 30 PM Screen Shot 2021-07-13 at 5 03 27 PM

@Beamanator
Copy link
Contributor

@parasharrajat which PR do you think could have broken this?

@parasharrajat
Copy link
Member

@Beamanator I think this #3942

@Beamanator
Copy link
Contributor

Hmm when I removed your changes from that PR I see this in android, so your changes may have almost fixed the issue haha. Do you see the same?

Screen Shot 2021-07-13 at 5 16 05 PM

@parasharrajat
Copy link
Member

parasharrajat commented Jul 13, 2021

So I just tested it on the smaller android device which is at version v1.0.77-2 and I didn't found this issue.

@roryabraham
Copy link
Contributor

roryabraham commented Jul 13, 2021

Going to try and fix this again

@roryabraham
Copy link
Contributor

roryabraham commented Jul 13, 2021

My latest attempt is here (it also fixes some style regressions). I'm not 100% sure if it will fix this issue because I've been unable to reproduce it so far. But again, I think there's a good chance that it might.

@Beamanator
Copy link
Contributor

Looks great @roryabraham - tested, approved, merged 💯

@Beamanator
Copy link
Contributor

I believe we can close this automatically b/c fix has been merged, no payouts are due.

@roryabraham
Copy link
Contributor

@isagoico @kavimuru can we please retest this in 1.0.77-3 and verify if the issue is solved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants