[Hold for Payment 10 August] Web - Chat - When Pasting the copied text in compose field there are 2 line breaks before and after the text

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel! https://www.upwork.com/jobs/~0112eb53bb4c90676c

---

Action Performed:

1. Open e.cash in Web
2. Navigate to a conversation that has some messages
3. In a message that only contains text, use the copy function. For web, hover over the message and a menu should appear
4. Paste the message in a text box

Expected Result:

The message must be shown in the text box without issues

Actual Result:

The size of the compose field there are 2 line breaks before and after the copied text

Workaround:

Unknown

Platform:

Where is this issue occurring?

Web ✔️
iOS
Android
Desktop App
Mobile Web

Version Number:
1.0.78-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Bug5152245_Issuecopy_Paste.mp4

Expensify/Expensify Issue URL:

View all open jobs on Upwork

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Triggered auto assignment to @Julesssss (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[parasharrajat]

@kavimuru Not able to reproduce, Could you please try pasting the same copied content here http://madebyevan.com/clipboard-test/

And share the output with us. It will help us debug.

[Julesssss]

Hi @kavimuru, I'm also not able to reproduce on Chrome, E.cash version v1.0.78-1. I tried a couple of different languages.

For now I'm removing the labels.

[kavimuru]

Hi @parasharrajat , I'm still able to reproduce with version v1.0.78-1. Attaching video which included reproducible steps and output from http://madebyevan.com/clipboard-test/

Reproducible.mp4

[Julesssss]

@kavimuru here's what I'm seeing with the same message:

Clearly this is still occurring for you so lets keep the issue open, but there's no need to block release for this.

[isagoico]

mmm I'm also able to reproduce this on my side Web version 1.0.78-1 (Windows / Chrome)

[Julesssss]

Hmm, I wonder what the differences between our environments is? 🤔

To rule everything out, here is what I'm using:

MacOS Big Sur: `11.4`
Chrome version:  `91.0.4472.114` ✅ 
Safari version: `14.1.1 (16611.2.7.1.4)` ✅ 
Expensify.cash version: `v1.0.78-1`

I wonder if OS system language could be to blame? Or perhaps specific user accounts?

[isagoico]

I'm more inclined to the OS system part since it's the only difference in our environments and I was able to reproduce in different testing accounts. 🤔

[isagoico]

Issue reproducible during KI retests

[isagoico]

Issue reproducible during KI retests

[Julesssss]

Just retested and I'm still not seeing the error 😕

Sharing this in Slack to get additional testers.

[laurenreidexpensify]

I've tried this on prod v1.0.79-4 in Chrome 91.0.4472.101 and can't replicate at all 🤔

[conorpendergrast]

I've also just tried in v1.0.79-4 in Chrome 91.0.4472.114 and can't replicate

[twisterdotcom]

v1.0.79-4 on Firefox, also can't replicate.

[isagoico]

Are you testing on Mac or Windows? I'm also unable to replicate on my MacOS, but in Windows it has been reproducible since this was reported.

[parasharrajat]

I'll test it on Windows. I am sure that it exists on Windows. I'll try to find the cause and fix it.

[twisterdotcom]

All Mac here yes. 🤔

[parasharrajat]

I confirm this is reproducible on Windows Platform (tested Edge & Chrome). Finding solution now.

[parasharrajat]

I have found the core issue and Solution as well. May be we can triage this issue and I can apply the fix. Or If we are no triaging then you can assign this to me and I will apply the fix.

Exaplanation:

1. On window platform, copy works a little differently. Its appends and prepends html & body tags to the html fragments. And each tag following a newline. HTML tags are successfully trimmed by Str.stripHtml in HTML to MD conversion. but not the newlines between tags.

<html>
<body>
<!--StartFragment--><span style="color: rgb(0, 0, 0); font-family: &quot;Times New Roman&quot;; font-size: medium; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; white-space: pre-wrap; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration-thickness: initial; text-decoration-style: initial; text-decoration-color: initial; display: inline !important; float: none;">test message</span><!--EndFragment-->
</body>
</html>

Fix:

1. We have to add another rule where we specify these special tags which need to be trimmed with the ending newline. For now HTML and body tag. We can not trim the converted string as it is possible that there were <br> tags for the converted newlines.

2. I think it would be good to match the ending newline chars with each tag. Thus updating the regex of each tag to match this.

Unix tends to use \n as a line separator; Windows tends to use \r\n as a line separator and Macs (up to OS 9) used to use \r as the line separator. (Mac OS X is Unix-y, so uses \n instead; there may be some compatibility situations where \r is used instead though.)

[Julesssss]

Would you like to take this issue @parasharrajat?

[parasharrajat]

Yeah Sure. My pleasure. I am already tackling other paste-related issues.

[MelvinBot]

Triggered auto assignment to @puneetlath (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[laurenreidexpensify]

@Julesssss just a reminder we need to have a Contributor Manager and Contributor Manager Engineer assigned the issue along with the Contributor, so that we can ensure the job is posted to Upwork + the contributor is hired and paid, and that the CME is able to review the PR.

[laurenreidexpensify]

Job posted on Upwork https://www.upwork.com/jobs/~0112eb53bb4c90676c

[isagoico]

Issue reproducible during KI retests

[parasharrajat]

Oh sorry I missed to update the lib version on NewDot

[isagoico]

Issue not reproducible during KI retests (Fixed 🎉)

[laurenreidexpensify]

Paid @parasharrajat 👍🏽