Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update E-common #4363

Merged
merged 1 commit into from
Aug 2, 2021
Merged

Update E-common #4363

merged 1 commit into from
Aug 2, 2021

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Aug 2, 2021

@Beamanator Please review.

Details

Fixed Issues

Fixes Following issues
#4188
#4066
#4169

Tests | QA Steps

1

  1. Open e.cash in Web
  2. Navigate to a conversation that has some messages
  3. In a message that only contains text, use the copy function. For web, hover over the message and a menu should appear
  4. Paste the message in a text box (Should be tested on Windows Web). NO emptty lines should appended and prepended.

2

  1. Navigate to a conversation that has some messages.
  2. Edit a message that contains &. & should be shown as & not &.

3

  1. Navigate to a conversation that has some messages.
  2. Paste the Text from MAC Note.app to the composer. No css should be pasted including other metadata.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@parasharrajat parasharrajat requested a review from a team as a code owner August 2, 2021 10:47
@MelvinBot MelvinBot requested review from deetergp and removed request for a team August 2, 2021 10:47
@Beamanator
Copy link
Contributor

Beamanator commented Aug 2, 2021

Hmm I copied some basic text from the Notes app and didn't see css or metadata, but I did see a bunch of preceding empty lines - I think this passes since the empty lines also exists in the staging app - just wanted to note here in case it's not known

Screen Shot 2021-08-02 at 1 27 30 PM

Copy link
Contributor

@Beamanator Beamanator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid! 👍

@parasharrajat
Copy link
Member Author

parasharrajat commented Aug 2, 2021

so that whitespace seems a different issue. I will look into it separately. Its coming from the newlines.

@Beamanator Beamanator merged commit 8033dc4 into Expensify:main Aug 2, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Aug 2, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@Beamanator
Copy link
Contributor

Merging since there's no code change here, and changing expensify-common hash tested well 👍

@OSBotify
Copy link
Contributor

OSBotify commented Aug 6, 2021

🚀 Deployed to staging in version: 1.0.82-8🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @francoisl in version: 1.0.83-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants