Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HTML-> MD Conversion #399

Merged
merged 4 commits into from
Jul 28, 2021
Merged

Fix HTML-> MD Conversion #399

merged 4 commits into from
Jul 28, 2021

Conversation

parasharrajat
Copy link
Member

anyone will you please review this?

[Explanation of the change or anything fishy that is going on]
Expensify/App#4066 (comment) for Expensify/App#4066
Expensify/App#4169 (comment) for Expensify/App#4169

Fixed Issues

$ Fixes Expensify/App#4066
$ Fixes Expensify/App#4169

Tests

  1. What unit/integration tests cover your change? What autoQA tests cover your change?
    Unit tests added.
  2. What tests did you perform that validates your changed worked?
    Manual text matching.

QA

  1. What does QA need to do to validate your changes?
    Message Formatting in New Exepnsify
  2. What areas to they need to test for regressions?
    Message Formatting in New Exepnsify

@parasharrajat parasharrajat requested a review from a team as a code owner July 27, 2021 10:23
@MelvinBot MelvinBot requested review from Gonals and removed request for a team July 27, 2021 10:23
@parasharrajat
Copy link
Member Author

parasharrajat commented Jul 27, 2021

@Gonals Please let me know what do you think about it? It seems linked issues are becoming priorities.

@Gonals Gonals merged commit 7ed3ca6 into Expensify:master Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants