[Hold] fixed spaces collapsing in Messages #3869

parasharrajat · 2021-07-02T18:25:07Z

Details

Fixed Issues

$ Fixes #3859

Tests

Do npm install to get the latest packages used.
Open E.cash local server.
Go to any conversation and send the following message.

0 space
 1 spaces
  2 spaces
   3 spaces
    4 spaces

QA Steps

Log in to e.cash and navigate to a conversation
Send the following text

0 space
 1 spaces
  2 spaces
   3 spaces
    4 spaces

Output should contain the same amount of spacing as added.

Tested On

Screenshots

Web | Desktop

Mobile Web

iOS

Android

jasperhuangg · 2021-07-06T02:12:12Z

src/components/RenderHTML/BaseRenderHTML.js

@@ -54,10 +54,14 @@ const EXTRA_FONTS = [
 *
 * @param {number} contentWidth - The content width provided to the HTML
 * component.
+ * @param {number} tagName - tagname


Can we provide a better description for this parameter? @parasharrajat

jasperhuangg

Left a comment about some JSDoc stuff. Also, tested it and it doesn't seem to work, am I missing something? This doesn't seem to happen on main. Were there any changes in expensify-common that I'm missing?

2021-07-06_10-13-12.mp4

parasharrajat · 2021-07-06T02:36:13Z

did you run 'npm install'? @jasperhuangg

jasperhuangg · 2021-07-07T04:25:24Z

@parasharrajat Ah forgot, make sure you include that in your testing instructions if there were changes to expensify-common.

parasharrajat · 2021-07-08T23:24:46Z

@jasperhuangg Please, let me know if you are facing some issues while testing.

jasperhuangg · 2021-07-09T00:42:06Z

@parasharrajat Still waiting on you to look into this.

parasharrajat · 2021-07-09T01:08:48Z

Sorry @jasperhuangg, I thought you are still facing the issue so I waiting to get a response over it.
Anyways, I have updated it. Thanks.

src/components/RenderHTML/BaseRenderHTML.js

jasperhuangg

@parasharrajat Looks good! One small grammatical fix.

Co-authored-by: Jasper Huang <jasperhu@usc.edu>

parasharrajat · 2021-07-09T12:26:54Z

@jasperhuangg Done. Thanks.

jasperhuangg

Awesome, thanks for your patience!

OSBotify · 2021-07-10T01:12:20Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

jasperhuangg · 2021-07-10T01:14:35Z

Ah crap, didn't see the HOLD on this. I opened up a revert #3969. Sorry for any inconvenience @parasharrajat!

OSBotify · 2021-07-14T19:53:29Z

🚀 Deployed to staging in version: 1.0.77-6🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

kavimuru · 2021-07-15T03:16:55Z

Chat - Spaces are not displayed after sending the message

Expected Result:

Spaces should be displayed in the message after it's sent

Actual Result:

No spaces are displayed in the conversation after sending the message

Actions Performed:

Log in to e.cash and navigate to a conversation
Send the following text
0 space
1 spaces
2 spaces
3 spaces
4 spaces

Platform:

iOS ✔️
mWeb ✔️
Android ✔️
Web ✔️

Build:

1.0.78-0

Notes/Images/Video:

Bug5152224_RPReplay_Final1626313159.mp4

parasharrajat · 2021-07-15T04:18:38Z

This PR is reverted. So the original issue still exists.

isagoico · 2021-07-15T18:19:21Z

@jasperhuangg We're good to check off this PR from the list if the PR was reverted right? CC @roryabraham

OSBotify · 2021-07-23T21:15:58Z

🚀 Deployed to production in version: 1.0.79-4🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

parasharrajat added 2 commits July 2, 2021 19:46

fix: spaces collapsing in Messages

3fb4767

fix Deprecated props on RenderHtml

83ae650

parasharrajat marked this pull request as ready for review July 4, 2021 02:33

parasharrajat requested a review from a team as a code owner July 4, 2021 02:33

MelvinBot requested review from jasperhuangg and removed request for a team July 4, 2021 02:34

jasperhuangg reviewed Jul 6, 2021

View reviewed changes

jasperhuangg requested changes Jul 6, 2021

View reviewed changes

parasharrajat requested a review from jasperhuangg July 8, 2021 02:37

fix comment

53bbb9a

jasperhuangg reviewed Jul 9, 2021

View reviewed changes

src/components/RenderHTML/BaseRenderHTML.js Outdated Show resolved Hide resolved

jasperhuangg previously approved these changes Jul 9, 2021

View reviewed changes

Update src/components/RenderHTML/BaseRenderHTML.js

6199c03

Co-authored-by: Jasper Huang <jasperhu@usc.edu>

parasharrajat dismissed jasperhuangg’s stale review via 6199c03 July 9, 2021 12:26

parasharrajat mentioned this pull request Jul 9, 2021

[Hold for Payment 30th July] Upgrade react-native-render-html to latest (6.0.0-beta.8) #3951

Closed

parasharrajat changed the title ~~fixed spaces collapsing in Messages~~ [Hold] fixed spaces collapsing in Messages Jul 9, 2021

jasperhuangg approved these changes Jul 10, 2021

View reviewed changes

jasperhuangg merged commit 2e5a7ee into Expensify:main Jul 10, 2021

This was referenced Jul 12, 2021

Deploy Checklist: Expensify.cash 2021-07-09 #3958

Closed

Deploy Checklist: Expensify.cash 2021-07-14 #4046

Closed

parasharrajat mentioned this pull request Jul 18, 2021

Spaces are not displayed after sending the message #3859

Closed

parasharrajat deleted the space-collapsing branch November 20, 2023 13:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hold] fixed spaces collapsing in Messages #3869

[Hold] fixed spaces collapsing in Messages #3869

parasharrajat commented Jul 2, 2021 •

edited

Loading

jasperhuangg Jul 6, 2021 •

edited

Loading

jasperhuangg left a comment

parasharrajat commented Jul 6, 2021 •

edited

Loading

jasperhuangg commented Jul 7, 2021

parasharrajat commented Jul 8, 2021

jasperhuangg commented Jul 9, 2021

parasharrajat commented Jul 9, 2021

jasperhuangg left a comment

parasharrajat commented Jul 9, 2021

jasperhuangg left a comment

OSBotify commented Jul 10, 2021

jasperhuangg commented Jul 10, 2021

OSBotify commented Jul 14, 2021

kavimuru commented Jul 15, 2021

parasharrajat commented Jul 15, 2021

isagoico commented Jul 15, 2021

OSBotify commented Jul 23, 2021

[Hold] fixed spaces collapsing in Messages #3869

[Hold] fixed spaces collapsing in Messages #3869

Conversation

parasharrajat commented Jul 2, 2021 • edited Loading

Details

Fixed Issues

Tests

QA Steps

Tested On

Screenshots

Web | Desktop

Mobile Web

iOS

Android

jasperhuangg Jul 6, 2021 • edited Loading

Choose a reason for hiding this comment

jasperhuangg left a comment

Choose a reason for hiding this comment

parasharrajat commented Jul 6, 2021 • edited Loading

jasperhuangg commented Jul 7, 2021

parasharrajat commented Jul 8, 2021

jasperhuangg commented Jul 9, 2021

parasharrajat commented Jul 9, 2021

jasperhuangg left a comment

Choose a reason for hiding this comment

parasharrajat commented Jul 9, 2021

jasperhuangg left a comment

Choose a reason for hiding this comment

OSBotify commented Jul 10, 2021

jasperhuangg commented Jul 10, 2021

OSBotify commented Jul 14, 2021

kavimuru commented Jul 15, 2021

Chat - Spaces are not displayed after sending the message

Expected Result:

Actual Result:

Actions Performed:

Platform:

Build:

Notes/Images/Video:

parasharrajat commented Jul 15, 2021

isagoico commented Jul 15, 2021

OSBotify commented Jul 23, 2021

parasharrajat commented Jul 2, 2021 •

edited

Loading

jasperhuangg Jul 6, 2021 •

edited

Loading

parasharrajat commented Jul 6, 2021 •

edited

Loading