[Hold for Payment 30th July] Upgrade react-native-render-html to latest (6.0.0-beta.8)

[jsamr]

This is a follow-up on a conversation I had with @puneetlath. The Foundry release has entered beta stage recently, and thus has stabilized a lot. I am confident that the official 6.0.0 release should be ready at some point this summer. Relevant resources to read: Announcing the Beta Foundry Release, Changelog

Benefits

Currently, Expensify.cash is using the 6.0.0-alpha.10 version, which lags behind a few important breaking changes and enhancements. The main advantages of integrating this new release:

• Test coverage has been risen significantly in the main repository (jest reports > 98%)
  
• API has stabilized a lot and it not expected to change before final release.
• Many little performance improvements (check the changelog referred above).
• The API is documented in depth which is great for contributors, check out documentation website.

Planning

• Upgrade version to latest beta and adapt code where required to keep the same level of functionality;
• Test all tags to make sure nothing breaks;
• Review best practices regarding react-native-render-html usage, and include refactorings to enforce those best practices.

Upwork job post: https://www.upwork.com/jobs/~01214906855dec6aa3

[MelvinBot]

Triggered auto assignment to @johncschuster (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[parasharrajat]

Thanks, @jsamr for such a great lib. I am moving with a solution on PR #3869.
But I am not covering Review best practices regarding react-native-render-html usage, and include refactorings to enforce those best practices..

[MelvinBot]

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[jsamr]

@parasharrajat Thank you for this update! As I've just stated in your PR, I don't think disabling whitespace collapsing is a good idea since originally I was hired to implement whitespace collasing in the engine! Moreover, the amount of testing should be significant since we must make sure all tags are rendered as expected.

[parasharrajat]

Ok. I see. But we want to fix the spaces issue. Any solution for that issue. Holding that PR for further investigation.

[jsamr]

@parasharrajat Preserving spaces for the specific use case laid out it #3859 is really a matter of design choice, so it should be discussed with a product owner. If you type 3 spaces in this very Github markdown editor, spaces will be collapsed. To preserve spaces, one should explicitly use a preserving space block such as <pre> (or create a custom tag which has a whitespace: 'pre' style applied to it). I don't know of any chat app that behaves like this, but as I said, it's just a matter of opinion. In any case, that should be handled at the Markdown → HTML conversion level!

[parasharrajat]

Yeah. Clearly. But there was no straight way to do it. We may need to add <p> Tags on our parsing and then break each line of text to <p>. Not sure if this works.

[marcaaron]

Proposal looks good to me.

I'm not sure how you all want to handle the open PR to bump, but I think we should let @jsamr do the transition and then we can see what additional changes are necessary (full disclosure, I'm not up to date on what changes you are proposing there @parasharrajat).

[MelvinBot]

Triggered auto assignment to @trjExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[marcaaron]

@trjExpensify maybe can sync with @puneetlath before creating the job

[parasharrajat]

@marcaaron I good with @jsamr handling the Migration. The issue I am trying to solve does require this migration. I have put that PR on hold.

[jsamr]

@marcaaron All good! I've just created a profile on Upwork, just need to wait for review before I can apply when the job is ready!

[MelvinBot]

Triggered auto assignment to @tgolen (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[trjExpensify]

Here you go @jsamr https://www.upwork.com/jobs/~01214906855dec6aa3!

[tgolen]

Sounds like maybe I don't need to do anything here? I've been a little out-of-the-loop on this one. Sounds like we're gonna go ahead and hire jsamr though, so yay!

[marcaaron]

I'd like to review these changes when they are ready thanks :)

[jsamr]

@marcaaron
Copy that!

[trjExpensify]

Hired! 👍

[puneetlath]

Reopening to ensure this gets paid out if no regressions.

[parasharrajat]

There is one regression on this PR. If we resize the browser app crashes. Somehow HTML source is being set to undefined and shallow matching of the prop is failing where it's trying to covert the undefined to object.

[jsamr]

@parasharrajat Yeah I think the current version is stricter and doesn't allow undefined. But since the html prop is required in the surrounding component BaseRenderHTML, I would assume that is the contract for this component.

App/src/components/RenderHTML/renderHTMLPropTypes.js

Line 5 in 3d35169

html: PropTypes.string.isRequired,

As I have not touched other parts aside from src/components/RenderHTML, I would guess the bug comes from another component consuming this one.

[parasharrajat]

@jsamr Thanks for the context. I will look into it.

[parasharrajat]

Sorry for the confusion but it seems that was no issue. npm install fixed it.

[marcaaron]

Melvin shoo!

[trjExpensify]

Paid.