Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP Staging] Revert "Fix Desktop - CMD + K is slow and laggy #3601" #3824

Merged
merged 1 commit into from
Jun 30, 2021
Merged

[CP Staging] Revert "Fix Desktop - CMD + K is slow and laggy #3601" #3824

merged 1 commit into from
Jun 30, 2021

Conversation

nickmurray47
Copy link
Contributor

@nickmurray47 nickmurray47 commented Jun 30, 2021 •
edited
Loading

Details

Reverts #3760 for causing search option regressions

Fixed Issues

$ #3818
$ #3821
$ #3829

Tests / QA Steps

  1. Verify that you can create a new chat and the search options can be filled in.
  2. Verify that selecting a search option from the list moves the attendee to the top.
  3. Verify that CMD+K brings you to the correct chat

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@nickmurray47 nickmurray47 self-assigned this Jun 30, 2021
@nickmurray47 nickmurray47 requested a review from a team as a code owner June 30, 2021 17:16
@MelvinBot MelvinBot requested review from joelbettner and removed request for a team June 30, 2021 17:16
@nickmurray47 nickmurray47 changed the title Revert "Fix Desktop - CMD + K is slow and laggy #3601" [HOLD] Revert "Fix Desktop - CMD + K is slow and laggy #3601" Jun 30, 2021
@nickmurray47
Copy link
Contributor Author

testing if this PR is the one that caused the following deploy blocker #3818

@nickmurray47 nickmurray47 changed the title [HOLD] Revert "Fix Desktop - CMD + K is slow and laggy #3601" [CP Staging] Revert "Fix Desktop - CMD + K is slow and laggy #3601" Jun 30, 2021
@nickmurray47 nickmurray47 mentioned this pull request Jun 30, 2021
Closed
tgolen
tgolen approved these changes Jun 30, 2021
View reviewed changes
Copy link
Contributor

@tgolen tgolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed this fixes the problem. I'm going to approve and merge this.

@parasharrajat
Copy link
Member

parasharrajat commented Jun 30, 2021 •
edited
Loading

@tgolen Also, I believe that it solves another issue #3829 worth testing.

@OSBotify
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@nickmurray47 nickmurray47 mentioned this pull request Jun 30, 2021
Closed
@tgolen tgolen merged commit 312e645 into main Jun 30, 2021
@tgolen tgolen deleted the revert-3760-thibault-FixSearchPageSlowIssue(CMD+K) branch June 30, 2021 17:57
github-actions bot pushed a commit that referenced this pull request Jun 30, 2021
@tgolen
Merge pull request #3824 from Expensify/revert-3760-thibault-FixSearc…
10ddb05 
…hPageSlowIssue(CMD+K)

[CP Staging] Revert "Fix Desktop - CMD + K is slow and laggy #3601"

(cherry picked from commit 312e645)
@OSBotify OSBotify mentioned this pull request Jun 30, 2021
Closed
@nickmurray47 nickmurray47 mentioned this pull request Jun 30, 2021
Closed
@OSBotify OSBotify mentioned this pull request Jun 30, 2021
Closed
22 tasks
github-actions bot pushed a commit that referenced this pull request Jun 30, 2021
@tgolen
Merge pull request #3824 from Expensify/revert-3760-thibault-FixSearc…
80c6451 
…hPageSlowIssue(CMD+K)

[CP Staging] Revert "Fix Desktop - CMD + K is slow and laggy #3601"

(cherry picked from commit 312e645)
@OSBotify OSBotify mentioned this pull request Jun 30, 2021
Merged
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging in version: 1.0.75-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

This was referenced Jul 7, 2021
Closed
Closed
@OSBotify OSBotify mentioned this pull request Jul 14, 2021
Closed
95 tasks
@fedirjh fedirjh mentioned this pull request Apr 11, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgolen tgolen tgolen approved these changes

@joelbettner joelbettner Awaiting requested review from joelbettner

Assignees

@nickmurray47 nickmurray47

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nickmurray47 @parasharrajat @OSBotify @tgolen