Chat switching using arrow keys does not open correct chat

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Log in to e.cash
2. Press CMD + K
3. Search for an user
4. Use arrow keys and enter to select an user

Expected Result:

Correct chat should open when using arrow keys

Actual Result:

User is taken to a random chat.

Workaround:

N/A

Platform:

Where is this issue occurring?

Web ✔️
iOS
Android
Desktop App ✔️
Mobile Web

Version Number: 1.0.75-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

View all open jobs on Upwork

---

From @iwiznia https://expensify.slack.com/archives/C01GTK53T8Q/p1625003088243400

chat switching is not working properly. What I did:

• CMD+K
• Wrote Hax, got a list of users
• Did arrow down twice so it selected Michael Haxiu
• Pressed enter
• Was taken to a "random" chat (it changes every time I do it between , Sara and Flo, which are ll in that list
  This is happening on staging on web and if it is not happening in prod, it's a deploy blocker

[MelvinBot]

Triggered auto assignment to @tgolen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[tgolen]

OK, looking into this to see what I can determine. Gonna try to reproduce it locally and debug what's happening.

[nickmurray47]

@timgolen I got assigned a similar deploy blocker issue here #3818 and I believe both are related to the same PR. I have a revert PR #3824 in the works if you want to pull that and test.

[tgolen]

OK. I'm not able to reproduce this at all locally or on production :( so I wouldn't be able to know if that revert fixes anything or not.

[tgolen]

Ah, I found my problem. I was skipping Search for an user

[tgolen]

I confirmed that the revert PR fixes the problem. I'll link the two together.

[nickmurray47]

Great!

[isagoico]

I was unable to reproduce this issue in Windows but won't close it yet since it was originally reproduced in MacOS (and I don't have a MacOS to test this) checking with the team

[iwiznia]

Odd, I can't reproduce this anymore... maybe we fixed it??? 😕

[iwiznia]

Oh, Tim has already reverted the PR that caused the bug.