Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search for participant is not working #3818

Closed
isagoico opened this issue Jun 30, 2021 · 15 comments
Closed

Search for participant is not working #3818

isagoico opened this issue Jun 30, 2021 · 15 comments
Assignees

Comments

@isagoico
Copy link

isagoico commented Jun 30, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Log in to e.cash
  2. Click on the FAB button
  3. Click on request money
  4. Enter an amount
  5. Use the search box to search for a participant

Expected Result:

Search should show results when looking for existing accounts.

Actual Result:

Search is not giving results after typing an existing user. Same is happening for New Chat and New Group

Workaround:

None found.

Platform:

Where is this issue occurring?

Web ✔️
iOS
Android
Desktop App
Mobile Web

Version Number: 1.0.75-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

image

Expensify/Expensify Issue URL:

View all open jobs on Upwork


From @aliabbasmalik8 https://expensify.slack.com/archives/C01GTK53T8Q/p1625003429246900

When I request money then search not working me on staging

@MelvinBot
Copy link

Triggered auto assignment to @nickmurray47 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@isagoico isagoico added the DeployBlockerCash This issue or pull request should block deployment label Jun 30, 2021
@github-actions github-actions bot added Hourly KSv2 and removed Daily KSv2 labels Jun 30, 2021
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@trjExpensify
Copy link
Contributor

@nickmurray47 can also confirm that this is broken for New Chat and New Group on 1.0.75-0 as well:

image

@isagoico isagoico changed the title IOU - Search for participant is not working Search for participant is not working Jun 30, 2021
@isagoico
Copy link
Author

Updated the title to reflect was @trjExpensify posted above 🔝

@nickmurray47
Copy link
Contributor

taking a look now

@nickmurray47
Copy link
Contributor

This PR from the staging checklist looks the most suspect #3760

@nickmurray47
Copy link
Contributor

Trying to see if we need to revert the whole PR or if there's a simple fix we can make.

@parasharrajat
Copy link
Member

parasharrajat commented Jun 30, 2021

Also, not too sure that if that PR really solves the original problem. A larger Dataset needs to be tested on that.

@nickmurray47
Copy link
Contributor

Ok, the reverted branch fixes the "search" issue. I think we will CP to Staging especially given the doubts that this PR would have solved the original problem in the first place.

@nickmurray47
Copy link
Contributor

The reverted branch also looks like it fixes the other deploy blocker #3821

@parasharrajat
Copy link
Member

I did notice one small thing the Fixes keyword on the issue template is changed to $ which does not automatically close the issues.

@nickmurray47
Copy link
Contributor

Did it use to be Fixes @parasharrajat? I agree that's annoying if the issue does not automatically close. We can make a change to the issue template if need be.

@parasharrajat
Copy link
Member

Yup, it was.

@nickmurray47 nickmurray47 removed the DeployBlockerCash This issue or pull request should block deployment label Jun 30, 2021
@nickmurray47
Copy link
Contributor

confirmed the fix on staging, closing

@nickmurray47
Copy link
Contributor

@parasharrajat can you make an issue or make a note of that template issue in our open source channel? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants