Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict self requests & naming convention changes #4063

Conversation

Santhosh-Sellavel
Copy link
Collaborator

@Dal-Papa

Details

Restricted user email or mobile number from search results.

Fixed Issues

$ #3572

Tests | QA Steps

Note: Have an account with an email and mobile number linked to test out all possible cases.

Case 1: Splitting bills:

  1. Click New
  2. Click Split Bill
  3. Enter your own email/mobile number in the search
  4. Your own email/mobile number will not appear in search results

Case 2: Requesting money:

  1. Click New
  2. Click Request Money
  3. Enter your own email/mobile number in the search
  4. Your own email/mobile number will not appear in search results

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android - Kindly test on Android.

Screenshots

Web

Profile
Web_Profile

Request
Web_Request

Mobile Web

Profile
Mobile_Web_Profile

Request
Mobile_Web_Request

Desktop

Profile
Desktop_Profile

Request
Desktop_Req

iOS

Profile
iOS_MyProfile

Request
Email
iOS_Email_req

Mobile Number
iOS_Mobile_req

@Santhosh-Sellavel Santhosh-Sellavel requested a review from a team as a code owner July 15, 2021 02:28
@MelvinBot MelvinBot requested review from ctkochan22 and removed request for a team July 15, 2021 02:28
@ctkochan22 ctkochan22 merged commit a4424c6 into Expensify:main Jul 15, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.78-3🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.79-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@aman-atg aman-atg mentioned this pull request Aug 17, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants