Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Bank Account RequestorStep UI #3986

Merged
merged 1 commit into from
Jul 12, 2021
Merged

Update Bank Account RequestorStep UI #3986

merged 1 commit into from
Jul 12, 2021

Conversation

NikkiWines
Copy link
Contributor

Details

  • Fixes the back button on the requestor step so that it takes you to the Bank Account step
  • Ensures that we're maintaining the requestorAddressState instead of accidentally resetting it

Fixed Issues

$ N/A Found while doing some manual testing

Tests/QA

  1. Log into E.cash with an account that does not have a bank account set up
  2. Navigate to /bank-account/new
  3. Following these steps, input the information to add a PENDING bank account
    • image
  4. When you get to the Requestor Step confirm that checking and unchecking the I am authorized to use my company bank account for business spend checkbox does not reset the value in the State dropdown
  5. Click on the < button in the top left of the view and confirm you're taken back to the Company Step.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen.Recording.2021-07-12.at.11.43.12.AM.mov

Mobile Web

Desktop

iOS

Android

update state to use requestorAddressState instead of requestorAddressCity
@NikkiWines NikkiWines requested a review from a team July 12, 2021 18:44
@NikkiWines NikkiWines self-assigned this Jul 12, 2021
@MelvinBot MelvinBot requested review from timszot and removed request for a team July 12, 2021 18:44
Copy link
Contributor

@timszot timszot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tests good

@timszot timszot merged commit e0d2943 into main Jul 12, 2021
@timszot timszot deleted the nikki-requestor-patch branch July 12, 2021 21:26
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.77-6🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.79-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants