Android - LHN - Period is displayed in between the user names of group chat in unread messages

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Lunch the app
2. Log in with any account

Expected Result:

Comma is displayed in between the user names for both read and unread groups

Actual Result:

Period is displayed in between the user names for the unread groups

Workaround:

Unknown

Platform:

Where is this issue occurring?

Web
iOS
Android ✔️
Desktop App
Mobile Web

Version Number:
1.0.78-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:

View all open jobs on Upwork

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Triggered auto assignment to @yuwenmemon (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[parasharrajat]

@roryabraham I think this is a side-effect of replacing the Text with ExpensiText. I found that we have height:18 set on these styles and if we remove it will be fixed. Also if you look closely, you will found that in focused mode the Chat title is not centered with respect to Avatar.

[roryabraham]

Sorry I didn't get to this yesterday. I'll work on getting this resolved now.

[roryabraham]

Confirmed that this doesn't seem to be happening on other platforms.

[roryabraham]

Sorry, I had a bunch of issues with my Android emulators + not being able to update the hosts file to access the VM API. So I wasn't able to reproduce this. Lame, I know, but I have to give this back to you @yuwenmemon because I'll be OOO next week. I'm guessing it's just a simple issue with the default lineHeight here

[isagoico]

Issue reproducible during KI retests

[yuwenmemon]

Hmmm... I'm actually not seeing this on the latest version of Master:

What kind of Android device was it specifically?

[parasharrajat]

So @yuwenmemon This issue started showing up when Rory moved the RN text to our Text component. Previously Line-height and height were set to 18px which had no issues. https://github.com/Expensify/Expensify.cash/blob/47494884adb24d23226edb0eb7d22d8240ecf979/src/styles/styles.js#L801-L806.

Now line height will be taken from Text component default which is 20 so issues are coming. We are in discussion on removing the line height from the Text component as it has caused many issues. But to fix this.
either we set the line height back to 18 or remove the height.

[isagoico]

Retested this after #4143 was CPd and it was a pass 🎉 Closing the issue