Use round avatar for E.Cash room avatar #4144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
yuwenmemon
commented
Jul 20, 2021
| @@ -1191,7 +1191,6 @@ const styles = { | |||
| avatarNormal: { | |||
| height: variables.componentSizeNormal, | |||
| width: variables.componentSizeNormal, | |||
| backgroundColor: themeColors.icon, | |||
There was a problem hiding this comment.
Without removing this, the background would appear square:
There was a problem hiding this comment.
Coool and it doesn't seem to affect the other icons. LGTM
TomatoToaster
approved these changes
Jul 20, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
95 tasks
5 tasks
60 tasks
|
🚀 Deployed to staging in version: 1.0.79-5🚀
|
|
This passed qa so I'm checking this off |
|
🚀 Deployed to production in version: 1.0.80-2🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@TomatoToaster please review
Details
Just changes the Avatar from being square to round
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/170939
Tests/QA
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android