Fix: blue screen issue on Safari Web #3927
Conversation
| @@ -269,6 +272,8 @@ class ReportActionItem extends Component { | |||
| <> | |||
| <PressableWithSecondaryInteraction | |||
| ref={el => this.popoverAnchor = el} | |||
| onPressIn={() => this.props.isSmallScreenWidth && ControlSelection.block()} | |||
| onPressOut={() => ControlSelection.unblock()} | |||
There was a problem hiding this comment.
NAB: Why not include this.props.isSmallScreenWidth && here too?
There was a problem hiding this comment.
This Change will block text selection at the root. But we have a feature where we select text on the web and then open the context menu to copy the selected part.
On the underhand Unblocking is fine to run everywhere as it will have no effect if select is not blocked.
|
LGTM, just had one comment lmk what you think. |
|
FYI, I tried many ways to fix this issue. There is no simple way. We could have blocked the selection on the Lower message component. But that does not work. We already have that. In IOS, I have found that If the main target has selection blocked and you try to open the menu over it. Safari will expand your touch until it found something to select. For this blue screen. There are two things that were messing around.
So I have to use this solution as a hack to fix it. Which Keep other platforms intact. |
|
@TomatoToaster I would like to request you to test one thing before we merge it. When you open the context menu, try to close it by tapping on the background grayed area. It should close. Let me know if that has no issues. I just want to be sure that it does not break anything. I have an IOS simulator but that is not good to really test these things. Please test it on Android, IOS, safari M-web. Thank you. |
|
@TomatoToaster Needs a push. Thanks. |
|
Looking forward to a merge if it looks good. |
|
This still looks good, but this got some merge conflicts for you to resolve. I tried testing this on my iOS device locally but it's not set up with our developer account and it turns out I need someone else to approve it 😞 . Instead I tested the modal closing on iOS and android through simulators. It looks like it's working fine and on safari's mweb too! For proper physical device testing, I think it will be fine to verify when it hits staging and we can actually download it. |
|
Ready. Updated |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging in version: 1.0.77-6🚀
|
|
🚀 Deployed to production in version: 1.0.79-4🚀
|
Details
Fixed Issues
$ Fixes #2705
Tests | QA Steps
Tested On
Screenshots
Web
Mobile Web
fix-blue.mp4
Desktop
iOS
Android